Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration change token support #2

Open
MichaCo opened this issue Nov 29, 2016 · 5 comments
Open

Configuration change token support #2

MichaCo opened this issue Nov 29, 2016 · 5 comments

Comments

@MichaCo
Copy link

MichaCo commented Nov 29, 2016

Hi,
It seems that the change token handling isn't implemented in this extension. At least I couldn't find it in code and I found it while playing with it and changing configuration but nothing happend ;)

Is this something you are going to add?
thanks
M

@nblumhardt
Copy link
Member

Hi Micha- thanks for the note. It seems like this would be a worthwhile addition, but there's no work in progress on it currently.

@nblumhardt nblumhardt changed the title The extension doesn't respect configuration change token Configuration change token support Dec 29, 2016
@szahn
Copy link

szahn commented Dec 12, 2017

+1

@SixtoSaez
Copy link

Not a lot of context to this old open issue. Willing to work on it but need a few more specifics.

@nblumhardt
Copy link
Member

Hi @SixtoSaez - thanks for jumping in. https://docs.microsoft.com/en-us/aspnet/core/fundamentals/change-tokens?view=aspnetcore-3.1 is what the OP is referring to. Shimming it in here will require some kind of sink wrapper that's capable of switching out file sinks under the hood in response to configuration changes - a proof of concept might use Serilog.Sinks.Map with an open sink limit of 1 to achieve this. Hope this helps!

@SixtoSaez
Copy link

Yes it does! I'll get up to date on the change tokens and the code you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants