Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to convert URLs to clickable HyperLinks #15

Open
augustoproiete opened this issue Sep 4, 2021 · 1 comment
Open

Add ability to convert URLs to clickable HyperLinks #15

augustoproiete opened this issue Sep 4, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs-design up-for-grabs
Milestone

Comments

@augustoproiete
Copy link
Member

Discussed in #11 (comment)

Originally posted by TonyValenti September 3, 2021
If a URL is logged, please convert it to a clickable HyperLink

@augustoproiete
Copy link
Member Author

augustoproiete commented Sep 4, 2021

Some initial thoughts:

  • Enabled by default with option to turn off, or Disabled by default with option to turn on?
  • Should URLs in message templates be automatically converted to hyperlinks? e.g. Log.Information("Site: https://serilog.net")?
  • Should URLs in properties be automatically converted to hyperlinks? e.g. Log.Information("Site: {url}", "https://serilog.net")?
  • Should we create a new format type where the user can opt-in to formatting as hyperlink? e.g. Log.Information("Site: {url:hyperlink}", "https://serilog.net")?
  • Depending on the answers above, should we scan every log message _after rendering and perform the conversion, or should we inspect message template and properties separately?
  • Should we also scan for email addresses and convert to a hyperlink with mailto:?
  • Should we also scan for file paths and convert to a hyperlink with file://?
  • What would be a good interface to allow users to apply a custom logic to detect/replace hyperlinks (intercept or passthrough)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs-design up-for-grabs
Development

No branches or pull requests

1 participant