Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Testing : using localhost not docker #11

Open
harikt opened this issue Jan 9, 2018 · 3 comments
Open

Testing : using localhost not docker #11

harikt opened this issue Jan 9, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@harikt
Copy link
Contributor

harikt commented Jan 9, 2018

Hi,

I am not using docker.

Just testing on the localhost with the changes made to configuration file.

Running

./run activerecord create
./run cake create
./run doctrine create
./run eloquent create
./run eloquent create

Every tests shows results. But only the ./run doctrine create is inserting record to the database.

The assert() doesn't do anything if there is no handler. So may be need to improve the tests?

Did you verified the data is being inserted ?

I agree the benchmark.ini settings are not considered.

@sergeyklay sergeyklay added the enhancement New feature or request label Jan 9, 2018
@sergeyklay
Copy link
Owner

@harikt Do you have any idea how to verify the data is being inserted w/o affecting to the measurements?

@harikt
Copy link
Contributor Author

harikt commented Jan 10, 2018

What do you think about

if (! $post->getId()) {
    throw new Exception("Didn't write to database");
}

Also I am wondering whether we should consider using tool like https://github.com/phpbench/phpbench : http://phpbench.readthedocs.io/en/latest/quick-start.html .

@sergeyklay
Copy link
Owner

sergeyklay commented Jan 10, 2018

Let's use for PhpBench a separate issue #15

@sergeyklay sergeyklay self-assigned this Jan 10, 2018
@sergeyklay sergeyklay removed their assignment Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants