Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter 'SIDC' should not an edit field #2913

Open
Tristina1788 opened this issue Apr 15, 2024 · 1 comment
Open

Filter 'SIDC' should not an edit field #2913

Tristina1788 opened this issue Apr 15, 2024 · 1 comment
Assignees
@lilitkarapetyan
Labels
bug Something isn't working

Comments

@Tristina1788
Copy link
Collaborator

Tristina1788 commented Apr 15, 2024 •
edited
Loading

🐞 Bug description

Filter 'SIDC' should not an edit field

🔢 Steps to Reproduce

Steps to reproduce the behavior:

  1. Play game with data wargame-l6nngxlk
  2. Click on 'Core Mapping' channel
  3. Click 'Add' on 'Filter' bar
  4. Select 'Sidc'
  5. Notice 'Sidc' show as an edit field

image

⚙️ Expected behavior

'Sidc' filter should be a textbox without 'Edit' button. And we can input 'SIDC' code for filter.

🖥️ Screenshots

💻 System information

  • Browser : Chrome
  • Browser Version : Version 120.0.6099.111

📝 Additional context
@Tristina1788 Tristina1788 added the bug Something isn't working label Apr 15, 2024
@IanMayo IanMayo assigned lilitkarapetyan and unassigned IanMayo Apr 15, 2024
@lilitkarapetyan lilitkarapetyan mentioned this issue Jul 1, 2024
Merged
7 tasks
@IanMayo
Copy link
Contributor

IanMayo commented Jul 4, 2024

I think the existing implementation is valid @Tristina1788

A user can use the Edit button to use the dialog to select which SIDC type they want to see filtered. (in addition to providing the raw text value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lilitkarapetyan lilitkarapetyan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanMayo @lilitkarapetyan @Tristina1788