Use legacy HttpServer in wallet RPC #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dispatcher with 5181c38 can cause crash of the daemon |
aivve
force-pushed
the
dev/legacy_wallet_rpc_srv
branch
from
1a71192 to
0a45807
Compare
This reverts commit 5181c38.
…karbowanec into dev/legacy_wallet_rpc_srv
|
For now we have used other approach #211 |
# Conflicts: # src/JsonRpcServer/JsonRpcServer.cpp # src/PaymentGateService/PaymentGateService.cpp # src/PaymentGateService/PaymentGateService.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to httplib's conflict with our dispatcher causing crashes on some RPC methods as a quick solution restore HttpServer in wallet RPC.
Older HttpServer and HttpClient without SSL support were taken as it's not needed for their use cases and doesn't work well. HttpClient is not used anywhere, it was just brought back together with HttpServer just in case.