Skip to content

make build shouldn't install and modify user's $PATH #2127

@stahnma

Description

@stahnma

I'm trying to package sequin into nixpkgs, and the instructions in your documentation to build from source say cd cli && make build, however make build does more than just build the binary. It also puts the binary in $HOME/.local/bin and adds that to $PATH. That is not a build step, it's an installation or setup step.

This means that I have to either patch the Makefile or just reverse engineer the build instructions because $HOME isn't available when building packages in a clean chroot (which is also the case for Fedora/Red Hat, Debian, etc)

I'd recommend separating these two steps into two different targets. (and not having just one shell script build_and_install, those aren't the same thing).

I'm happy to make a patch for this if you'd like, just let me know if you'd accept it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions