Temporarily Fix the api/core/v3 dependency #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kruse <[email protected]>
|
Should the fix be ported to the core/v3.7.x series? |
jamesdphillips
approved these changes
Sep 21, 2022
I created #4871 so we don't forgot. |
c-kruse
added a commit
that referenced
this pull request
Sep 26, 2022
Signed-off-by: Christian Kruse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
We've landed ourselves in a state. develop/6 currently does not build since the api/core/v3 dependency is pointing at a squashed commit.
This updates the dep to a commit that is not likely to ever be squished (the current develop/6 HEAD), but I believe we should follow up with merging the core/v3 changes into main and publishing a new v3.x tag for it to point at before a release.