Merge pull request #115 from sendbird/v4.2.19

Add 4.2.19.

Author: sf-tyler-jeong

CHANGELOG.md

@@ -1,3 +1,10 @@
+## v4.2.19 (Jul 4, 2024)
+
+### Improvements
+- Fixed a bug that channels are not added when `includeEmpty` is `false` in `GroupChannelCollection`
+- Fixed a bug regarding a channel event when leaving a `GroupChannel`
+- Fixed a bug regarding the filtering on multi `GroupChannelCollection`s
+
 ## v4.2.18 (Jun 26, 2024)
 
 ### Improvements

README.md

@@ -50,7 +50,7 @@ Before installing Sendbird Chat SDK, you need to create a Sendbird application o
 
 ```yaml
 dependencies:
-  sendbird_chat_sdk: ^4.2.18
+  sendbird_chat_sdk: ^4.2.19
 ```
 
 - Run `flutter pub get` command in your project directory.

lib/src/internal/main/chat/chat.dart

@@ -62,7 +62,7 @@ part 'chat_notifications.dart';
 part 'chat_push.dart';
 part 'chat_user.dart';
 
-const sdkVersion = '4.2.18';
+const sdkVersion = '4.2.19';
 
 // Internal implementation for main class. Do not directly access this class.
 class Chat with WidgetsBindingObserver {

lib/src/internal/main/chat_manager/collection_manager/collection_manager.dart

@@ -454,12 +454,10 @@ class InternalGroupChannelHandlerForCollectionManager
         }
       }
 
-      // (includeEmpty == false)
       if (channel is GroupChannel) {
         _collectionManager.sendEventsToGroupChannelCollectionList(
           eventSource: CollectionEventSource.eventMessageReceived,
           addedChannels: [channel],
-          doNotUpsertAddedChannels: true,
         );
       }
     }

lib/src/internal/main/chat_manager/collection_manager/group_channel_collection_manager.dart

@@ -117,7 +117,6 @@ extension GroupChannelCollectionManager on CollectionManager {
     List<GroupChannel>? addedChannels,
     List<GroupChannel>? updatedChannels,
     List<String>? deletedChannelUrls,
-    bool doNotUpsertAddedChannels = false, // (includeEmpty == false)
   }) async {
     sbLog.d(StackTrace.current, eventSource.toString());
 
@@ -126,8 +125,14 @@ extension GroupChannelCollectionManager on CollectionManager {
       if (deletedChannelUrls != null) {
         await _chat.dbManager.deleteGroupChannels(deletedChannelUrls);
       }
-      if (addedChannels != null && !doNotUpsertAddedChannels) {
-        await _chat.dbManager.upsertGroupChannels(addedChannels);
+      if (addedChannels != null) {
+        if (eventSource == CollectionEventSource.channelLoadMore ||
+            eventSource == CollectionEventSource.channelCacheLoadMore ||
+            eventSource == CollectionEventSource.channelChangeLogs) {
+          // Do upsertGroupChannels() in sendEventsToGroupChannelCollection().
+        } else {
+          await _chat.dbManager.upsertGroupChannels(addedChannels);
+        }
       }
       if (updatedChannels != null) {
         await _chat.dbManager.upsertGroupChannels(updatedChannels);
@@ -173,18 +178,28 @@ extension GroupChannelCollectionManager on CollectionManager {
 
     //+ [DBManager]
     if (_chat.dbManager.isEnabled()) {
-      if (eventSource == CollectionEventSource.channelLoadMore ||
-          eventSource == CollectionEventSource.channelCacheLoadMore) {
-        if (deletedChannelUrls != null) {
-          await _chat.dbManager.deleteGroupChannels(deletedChannelUrls);
-        }
-        if (addedChannels != null) {
+      if (deletedChannelUrls != null) {
+        await _chat.dbManager.deleteGroupChannels(deletedChannelUrls);
+      }
+      if (addedChannels != null) {
+        if (eventSource == CollectionEventSource.channelLoadMore ||
+            eventSource == CollectionEventSource.channelCacheLoadMore ||
+            eventSource == CollectionEventSource.channelChangeLogs) {
+          List<GroupChannel> unavailableChannels = [];
+          for (final channel in addedChannels) {
+            if (!await channelCollection.canAddChannel(eventSource, channel)) {
+              unavailableChannels.add(channel);
+            }
+          }
+          for (final channel in unavailableChannels) {
+            addedChannels.remove(channel);
+          }
           await _chat.dbManager.upsertGroupChannels(addedChannels);
         }
-        if (updatedChannels != null) {
-          // Not used
-          await _chat.dbManager.upsertGroupChannels(updatedChannels);
-        }
+      }
+      if (updatedChannels != null) {
+        // Not used
+        await _chat.dbManager.upsertGroupChannels(updatedChannels);
       }
     }
     //- [DBManager]

lib/src/internal/main/chat_manager/collection_manager/message_collection_manager.dart

@@ -73,12 +73,10 @@ extension MessageCollectionManager on CollectionManager {
       );
     }
 
-    // (includeEmpty == false)
     if (channel is GroupChannel) {
       sendEventsToGroupChannelCollectionList(
         eventSource: CollectionEventSource.eventMessageSent,
         addedChannels: [channel],
-        doNotUpsertAddedChannels: true,
       );
     }
   }

lib/src/internal/main/chat_manager/command_manager.dart

@@ -1000,7 +1000,7 @@ class CommandManager {
               }
             }
             _chat.eventManager.notifyUserLeft(groupChannel, member);
-            _chat.eventManager.notifyChannelMemberCountChanged([groupChannel]);
+            // _chat.eventManager.notifyChannelMemberCountChanged([groupChannel]); // Check
           }
         }
       }

lib/src/public/main/collection/group_channel_collection/group_channel_collection.dart

@@ -255,14 +255,17 @@ class GroupChannelCollection {
       return false;
     }
 
-    // (includeEmpty == false)
     if (_query.includeEmpty == false) {
-      if (addedChannel.lastMessage == null) {
-        return false;
-      } else {
-        if (eventSource == CollectionEventSource.eventMessageSent ||
-            eventSource == CollectionEventSource.eventMessageReceived) {
-          return true;
+      if (checkToUpdateChannel == false) {
+        if (eventSource == CollectionEventSource.channelCacheLoadMore ||
+            eventSource == CollectionEventSource.channelLoadMore) {
+          if (addedChannel.lastMessage == null) {
+            return false;
+          }
+        } else if (eventSource == CollectionEventSource.eventMessageSent) {
+          if (addedChannel.lastMessage == null) {
+            return true; // Check
+          }
         }
       }
     }
@@ -321,13 +324,17 @@ class GroupChannelCollection {
       }
     }
 
-    // if (eventSource == CollectionEventSource.channelChangeLogs) { // Check
-    if (await _chat.dbManager.canAddChannel(
-            query: _query, channelUrl: addedChannel.channelUrl) ==
-        false) {
-      return false;
+    if (checkToUpdateChannel == false) {
+      //+ DBManager
+      if (_chat.dbManager.isEnabled()) {
+        if (await _chat.dbManager.canAddChannel(
+                query: _query, channelUrl: addedChannel.channelUrl) ==
+            false) {
+          return false;
+        }
+      }
+      //- DBManager
     }
-    // }
 
     return true;
   }

pubspec.yaml

@@ -1,6 +1,6 @@
 name: sendbird_chat_sdk
 description: With Sendbird Chat for Flutter, you can easily build an in-app chat with all the essential messaging features.
-version: 4.2.18
+version: 4.2.19
 homepage: https://sendbird.com
 repository: https://github.com/sendbird/sendbird-chat-sdk-flutter
 documentation: https://sendbird.com/docs/chat/sdk/v4/flutter/getting-started/send-first-message