-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add githubReleaseAssets option #809
base: master
Are you sure you want to change the base?
feat: Add githubReleaseAssets option #809
Conversation
1aed3e4
to
0370eb5
Compare
Includes the addition of a new option githubReleaseAssets to replace the old assets option. The assets option is identical to the option found in the git plugin but is ambiguous when used in shared configuration packages. Fixes: semantic-release#808
0370eb5
to
8a17388
Compare
Having seen your issue #808, I do not subscribe to introducing a new config property
Thinking real loud here, I believe we can do better by leaning towards a priority styles solution where the level of definition of the |
This still uses
ok, so we rename it To be fair, the simplicity in naming here is the thing that makes it difficult to use. Which is the more important thing
I think the above change addresses this.
That would also a breaking change. a default will have to be put in place, and it more than likely will not match what people have in place. I additionally postulate that breaks the simplicity ideal. It also means that other plugins will have to follow suite. It is not a common pattern in the semantic-release eco-system. |
This is the way the config should just operate... when there's an I can easily assume that this is how the package currently functions, but considering that it isn't (I still want verify this behavior), we gotta just fix exactly that 🤔 Let's continue this discussion in #808 |
The problem isn't priority of resolution. the problem is that a single key in a json object cannot represent 2 different settings
I don't disagree, My point here is that the argument against a breaking change isn't really relevant, as it would potentially be a breaking change in either case. |
Includes the addition of a new option githubReleaseAssets to replace the old assets option. The assets option is identical to the option found in the git plugin but is ambiguous when used in shared configuration packages.
Fixes: #808