Skip to content

Commit ca6d9e3

Browse files
authored
Merge pull request #264 from seleniumbase/add-missing-optional-parameter
Allow a custom timeout when waiting for link text
2 parents 6f0fce3 + 2be2fcc commit ca6d9e3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,13 +254,14 @@ def click_link_text(self, link_text, timeout=settings.SMALL_TIMEOUT):
254254
timeout = self.__get_new_timeout(timeout)
255255
if self.browser == 'phantomjs':
256256
if self.is_link_text_visible(link_text):
257-
element = self.wait_for_link_text_visible(link_text)
257+
element = self.wait_for_link_text_visible(
258+
link_text, timeout=timeout)
258259
element.click()
259260
return
260261
self.open(self.__get_href_from_link_text(link_text))
261262
return
262263
if not self.is_link_text_present(link_text):
263-
self.wait_for_link_text_present(link_text)
264+
self.wait_for_link_text_present(link_text, timeout=timeout)
264265
pre_action_url = self.get_current_url()
265266
try:
266267
element = self.wait_for_link_text_visible(

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
setup(
1919
name='seleniumbase',
20-
version='1.17.19',
20+
version='1.17.20',
2121
description='Reliable Browser Automation & Testing Framework',
2222
long_description=long_description,
2323
long_description_content_type='text/markdown',

0 commit comments

Comments
 (0)