Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CreateIfMissing to false when copyExisting #62

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Set CreateIfMissing to false when copyExisting #62

merged 5 commits into from
Apr 12, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Apr 9, 2024 •
edited
Loading

Describe your changes and provide context

  • Fixes issue with queries which have prove = true
  • SC query would initially fail this check because of this previous PR LoadVersion should open DB with read only #61 , downstream it would panic since it calls scStore.Close()
  • Sets CreateIfMissing to false when copyExisting is true

Testing performed to validate your change

  • Verified on node

@Kbhat1 Kbhat1 requested a review from yzang2019 April 9, 2024 22:45
@Kbhat1 Kbhat1 changed the title Allow ReadOnly + CreateDB if missing Set CreateIfMissing to false when copyExisting Apr 10, 2024
@Kbhat1 Kbhat1 requested a review from philipsu522 April 10, 2024 17:27
@Kbhat1 Kbhat1 merged commit 22bf439 into main Apr 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzang2019 yzang2019 yzang2019 approved these changes

@philipsu522 philipsu522 philipsu522 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kbhat1 @philipsu522 @yzang2019