Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intercom] Explicit setting of integrations prevents sending of user_hash. #308

Open
SegmentDestinationsBot opened this issue Dec 10, 2019 · 0 comments

Comments

@SegmentDestinationsBot
Copy link
Contributor

Migrated from #10 by @more-ron

We a have a code that dynamically turns on or off Intercom integration depending on the user.

We hit a condition when it should send it to Intercom but it doesn't. It does try to send it but it's missing the user_hash.

        analytics.identify('id', { ... }, {
          Intercom: { user_hash: 'x' },
          integrations: {
            All: true,
            ...,
            Intercom: true
          }
        });

Removing the explicit setting fixed it.

        analytics.identify('id', { ... }, {
          Intercom: { user_hash: 'x' },
          integrations: {
            All: true,
            ...
          }
        });

However that just a work around and it makes the backend code a bit more complicated now that it has to decide to include the Intercom key rather than just setting the value to either true or false.

It's also setting a trap for developers expecting it to just work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant