Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new button for redirect to scholarx platform #1637

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Add new button for redirect to scholarx platform #1637

merged 3 commits into from
Jul 3, 2024

Conversation

kamalchakma1
Copy link
Contributor

@kamalchakma1 kamalchakma1 commented Jul 3, 2024

Purpose

The purpose of this PR is to fix #1635

Goals

Approach

Screenshots

after

Preview Link

https://pr-1636-sef-site.surge.sh/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Related PRs

Learning

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kamalchakma1, Can we add the button below the main paragraph
image

Also use the blue color button and change the button text to visit scholarx.

@kamalchakma1
Copy link
Contributor Author

Hey, yes we can do that. I will do it.

@mayura-andrew
Copy link
Member

how about add VISIT SCHOLARX 2024? @anjula-sack

@kamalchakma1
Copy link
Contributor Author

kamalchakma1 commented Jul 3, 2024

Hi, I have added the changes. can you check once?

buttonadded

@mayura-andrew
Copy link
Member

can add space between new button and that container ?
image

@kamalchakma1
Copy link
Contributor Author

kamalchakma1 commented Jul 3, 2024

hi @mayura-andrew , I have added space between button and other containers, please have a look.

spaceadded

@anjula-sack anjula-sack changed the title new button added for redirect to scholarx platform Add new button for redirect to scholarx platform Jul 3, 2024
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @kamalchakma1

@anjula-sack anjula-sack merged commit f41229c into sef-global:master Jul 3, 2024
1 check passed
@mayura-andrew
Copy link
Member

@kamalchakma1 Good Job! Thank you :)

@kamalchakma1
Copy link
Contributor Author

Thank you! @kamalchakma1

You welcome !

@kamalchakma1
Copy link
Contributor Author

@kamalchakma1 Good Job! Thank you :)

Thank you! You welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button to got to scholarx on the new scholarx page
3 participants