include the ror url as identifier for Institution schema.org #2379

Author: stuzart

app/helpers/institutions_helper.rb

@@ -3,8 +3,8 @@ def can_create_institutions?
     Institution.can_create?
   end
 
-  def ror_link(ror_id)
-    ror_id.blank? ? text_or_not_specified(nil) : link_to("https://ror.org/#{ror_id}", "https://ror.org/#{ror_id}", target: "_blank", rel: "noopener")
+  def ror_link(ror_url)
+    ror_url.blank? ? text_or_not_specified(nil) : link_to(ror_url, ror_url, target: "_blank", rel: "noopener")
   end
 
   def other_departments(institution)

app/models/institution.rb

@@ -66,6 +66,12 @@ def typeahead_hint
     end
   end
 
+  def ror_url
+    return nil unless ror_id.present?
+
+    "https://ror.org/#{ror_id}"
+  end
+
   private
 
   def validate_base_title_presence

app/views/institutions/_resource_list_item.html.erb

@@ -1,4 +1,4 @@
-<%= list_item_attribute "ROR ID", ror_link(resource.ror_id) %>
+<%= list_item_attribute "ROR ID", ror_link(resource.ror_url) %>
 <%= list_item_attribute "Department", text_or_not_specified(resource.department) %>
 <%= list_item_attribute "Country", (country_text_or_not_specified  resource.country) %>
 <%= list_item_optional_attribute "City", h(resource.city) %>

lib/seek/bio_schema/resource_decorators/institution.rb

@@ -4,7 +4,8 @@ module ResourceDecorators
       # Decorator that provides extensions for an Institution
       class Institution < Thing
         schema_mappings full_address: :address,
-                        image: :logo
+                        image: :logo,
+                        ror_url: :identifier
 
         def schema_type
           'ResearchOrganization'

test/unit/bio_schema/schema_ld_generation_test.rb

@@ -698,6 +698,7 @@ def setup
       '@id' => "http://localhost:3000/institutions/#{institution.id}",
       "name"=>"Manchester Institute of Biotechnology, University of Manchester",
       'url' => 'http://www.manchester.ac.uk/',
+      'identifier' => 'https://ror.org/027m9bs27',
       "address"=>{"address_country"=>"GB", "address_locality"=>"Manchester", "street_address"=>"Manchester Centre for Integrative Systems Biology, MIB/CEAS, The University of Manchester Faraday Building, Sackville Street, Manchester M60 1QD United Kingdom"}
     }