Better error handling and more informative error messages.

Author: whomingbird

lib/seek/doi/parser.rb

@@ -4,34 +4,44 @@
 module Seek
   module Doi
     class Parser
-
       DOI_ENDPOINT = 'https://doi.org'.freeze
-      def self.parse(doi)
-        return if doi.blank?
 
+      def self.parse(doi)
         agency = get_doi_ra(doi)
+
         case agency
         when 'DataCite'
           Seek::Doi::Parsers::DataciteParser.new.parse(doi)
         when 'Crossref'
           Seek::Doi::Parsers::CrossrefParser.new.parse(doi)
         else
-          Rails.logger.warn("Unsupported DOI registration agency: #{agency}")
-          {}
+          raise Seek::Doi::RANotSupported, "DOI registration agency '#{agency}' is not supported."
         end
+      rescue OpenURI::HTTPError => e
+        # Handle RA resolution issues
+        raise Seek::Doi::FetchException, "Error resolving DOI #{doi}: #{e.message}"
+      rescue Seek::Doi::BaseException
+        raise # Re-raise already handled domain exceptions
       rescue StandardError => e
-        Rails.logger.error("DOI parsing failed for #{doi}: #{e.message}")
-        {}
+        # Fallback for truly unexpected errors
+        raise Seek::Doi::FetchException, "Unexpected error resolving DOI #{doi}: #{e.message}"
       end
 
       private_class_method def self.get_doi_ra(doi)
-        prefix = doi.split('/').first
-        url = DOI_ENDPOINT+"/ra/#{prefix}"
-        data = JSON.parse(URI.open(url).read)
-        data.dig(0, 'RA') # => "DataCite", "Crossref", etc.
-      rescue StandardError => e
-        Rails.logger.warn("Could not determine RA for DOI #{doi}: #{e.message}")
-        nil
+        url = "#{DOI_ENDPOINT}/ra/#{doi}"
+        response = URI.open(url).read
+        data = JSON.parse(response)
+        ra = data.dig(0, 'RA')
+        status = data.dig(0, 'status')
+
+        case status
+        when 'Invalid DOI'
+          raise Seek::Doi::MalformedDOIException, "Invalid DOI format: #{doi}."
+        when 'DOI does not exist'
+          raise Seek::Doi::NotFoundException, "DOI does not exist: #{doi}."
+        end
+        raise Seek::Doi::NotFoundException, "No registration agency found for DOI #{doi}" if ra.blank?
+        ra
       end
     end
   end

test/unit/doi/doi_parser_exception_test.rb

@@ -0,0 +1,51 @@
+require 'test_helper'
+
+class DoiParserExceptionTest < ActiveSupport::TestCase
+
+  test 'raises RANotSupported for mEDRA DOI' do
+    VCR.use_cassette('doi/medra_ra') do
+      doi = '10.19232/uv4pb.2018.2.00'
+      assert_equal 'mEDRA', Seek::Doi::Parser.send(:get_doi_ra, doi)
+    end
+  end
+
+  # Test that a DOI registered under mEDRA raises the correct exception
+  test 'raises RANotSupported for mEDRA DOI11' do
+    VCR.use_cassette('doi/medra_ra') do
+      doi = '10.19232/uv4pb.2018.2.00'
+      error = assert_raises(Seek::Doi::RANotSupported) do
+        Seek::Doi::Parser.parse(doi)
+      end
+      assert_equal "DOI registration agency 'mEDRA' is not supported.", error.message
+    end
+  end
+
+
+  test 'raises NotFoundException for fake DOI' do
+    VCR.use_cassette('doi/fake_doi') do
+      doi = '10.19232/fake.2020.1.23'
+      error = assert_raises(Seek::Doi::NotFoundException) do
+        Seek::Doi::Parser.send(:get_doi_ra, doi)
+      end
+      assert_equal 'DOI does not exist: 10.19232/fake.2020.1.23.', error.message
+    end
+  end
+
+  test 'raises MalformedDOIException for invalid DOI' do
+    VCR.use_cassette('doi/invalid_doi') do
+      doi = 'hello_march'
+      error = assert_raises(Seek::Doi::MalformedDOIException) do
+        Seek::Doi::Parser.send(:get_doi_ra, doi)
+      end
+      assert_equal 'Invalid DOI format: hello_march.', error.message
+    end
+  end
+
+end
+
+
+# resource not found
+#10.31234/osf.io/8s4xq
+
+# phd thesis can not be resolved
+#10.5445/IR/1000055628