Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn start leads to TypeError #4

Open
flosse opened this issue Oct 8, 2019 · 7 comments
Open

yarn start leads to TypeError #4

flosse opened this issue Oct 8, 2019 · 7 comments

Comments

@flosse
Copy link
Member

flosse commented Oct 8, 2019

That's what I did:

git clone https://github.com/MartinKavik/seed-quickstart-webpack
cd seed-quickstart-webpack
yarn
yarn start

That's the error msg:
Bildschirmfoto_2019-10-08_17-05-25

@flosse
Copy link
Member Author

flosse commented Oct 8, 2019

...the funny thing is, I try to move from JS/NPM to Rust just because of this kind of problems ;-)

@MartinKavik
Copy link
Member

MartinKavik commented Oct 8, 2019

It seems that they were playing with fs.promises - jprichardson/node-fs-extra#551 (comment).

And it's probably the reason why your promises are undefined - https://github.com/wasm-tool/wasm-pack-plugin/blob/872af9ec5f57837c2234a488a76a407ff227b40f/plugin.js#L120.

So it's possible that I (and CI) have a little bit different NodeJS version..
And you know the JS drill.. what's your NodeJS version and OS, please?

@flosse
Copy link
Member Author

flosse commented Oct 8, 2019

what's your NodeJS version and OS, please?

  • node v10.15.3
  • npm 6.4.1
  • yarn 1.13.0
  • nixos 19.03

@MartinKavik
Copy link
Member

Issue in wasm-pack-plugin: wasm-tool/wasm-pack-plugin#69

Temporary workaround: Just copy https://raw.githubusercontent.com/wasm-tool/wasm-pack-plugin/2d74352d703526508e2de95d6b1cacbca1b2101f/plugin.js to /node_modules/@wasm-tool/wasm-pack-plugin/plugin.js

@fattenap
Copy link
Contributor

This looks like it may have been resolved in the current version on [email protected]

@MartinKavik
Copy link
Member

This looks like it may have been resolved in the current version on [email protected]

@fattenap Are you sure? My PR hasn't been merged to wasm-pack and the bug is specific to only some OSs and NodeJS versions - it's not super easy to reproduce it.

Also there is still wasm-pack-plugin v. 1.0.1 in our package.json because newer versions brake our CI (I don't remember the error).

@fattenap
Copy link
Contributor

Oh, I didn't realise it was for specific Node versions. Reopening.

@fattenap fattenap reopened this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants