Add phone field to user traits

Author: Inbal Tako

README.md

@@ -100,7 +100,7 @@ context = securenative.context_builder(ip = '127.0.0.1', client_token = 'SECURED
         headers = { 'user-agent' => 'Mozilla/5.0 (iPad; U; CPU OS 3_2_1 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Mobile/7B405' })
 
 event_options = EventOptionsBuilder(event_type = EventTypes::LOG_IN,
-        user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]'),
+        user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]', '+1234567890'),
         context = context, properties = {prop1 => 'CUSTOM_PARAM_VALUE', prop2 => true, prop3 => 3}).build
 
 securenative.track(event_options)
@@ -120,7 +120,7 @@ def track(request)
     context = SecureNative.context_builder.from_http_request(request).build
 
     event_options = EventOptionsBuilder(event_type = EventTypes::LOG_IN,
-            user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]'),
+            user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]', '+1234567890'),
             context = context, properties = {prop1 => 'CUSTOM_PARAM_VALUE', prop2 => true, prop3 => 3}).build
 
     securenative.track(event_options)
@@ -143,7 +143,7 @@ def verify(request)
     context = SecureNative.context_builder.from_http_request(request).build
 
     event_options = EventOptionsBuilder(event_type = EventTypes::LOG_IN,
-        user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]'),
+        user_id = '1234', user_traits = UserTraits('Your Name', '[email protected]', '+1234567890'),
         context = context, properties = {prop1 => 'CUSTOM_PARAM_VALUE', prop2 => true, prop3 => 3}).build
 
     verify_result = securenative.verify(event_options)

VERSION

@@ -1 +1 @@
-0.1.16
+0.1.17

lib/securenative/event_manager.rb

@@ -130,6 +130,7 @@ def self.serialize(obj)
         userTraits: {
             name: obj.user_traits.name,
             email: obj.user_traits.email,
+            phone: obj.user_traits.phone,
             createdAt: obj.user_traits.created_at
         },
         request: {

lib/securenative/event_options_builder.rb

@@ -1,11 +1,20 @@
 class EventOptionsBuilder
   MAX_PROPERTIES_SIZE = 10
 
-  def initialize(event_type, user_id, user_traits, user_name, email, created_at, context, properties, timestamp)
+  def initialize(event_type, user_id, user_traits, user_name, email, phone, created_at, context, properties, timestamp)
+    traits = UserTraits(user_name)
+    if user_name && email && phone && created_at
+      traits = UserTraits(user_name, email, phone, created_at)
+    elsif user_name && email && phone
+      traits = UserTraits(user_name, email, phone)
+    elsif user_name && email
+      traits = UserTraits(user_name, email)
+    end
+
     @event_options = EventOptions(event_type)
     @event_options.user_id = user_id
     @event_options.user_traits = user_traits if user_traits
-    @event_options.user_traits = UserTraits(name, email, created_at) if user_name && email && created_at
+    @event_options.user_traits = traits
     @event_options.context = context
     @event_options.properties = properties
     @event_options.timestamp = timestamp

lib/securenative/models/user_traits.rb

@@ -1,10 +1,11 @@
 class UserTraits
-  attr_reader :name, :email, :created_at
-  attr_writer :name, :email, :created_at
+  attr_reader :name, :email, :phone, :created_at
+  attr_writer :name, :email, :phone, :created_at
 
-  def initialize(name = nil, email = nil, created_at = nil)
+  def initialize(name = nil, email = nil, phone = nil, created_at = nil)
     @name = name
     @email = email
     @created_at = created_at
+    @phone = phone
   end
 end

spec/spec_api_manager.rb

@@ -9,15 +9,15 @@
   end
   let(:event_options) do
     EventOptionsBuilder(event_type = EventTypes.LOG_IN, user_id = 'USER_ID',
-                        user_traits = UserTraits('USER_NAME', 'USER_EMAIL'),
+                        user_traits = UserTraits('USER_NAME', 'USER_EMAIL', '+1234567890'),
                         properties = {prop1: 'CUSTOM_PARAM_VALUE', prop2: true, prop3: 3}).build
   end
 
   it 'tracks an event' do
     options = ConfigurationBuilder(api_key = 'YOUR_API_KEY', auto_send = true, interval = 10, api_url = 'https://api.securenative-stg.com/collector/api/v1')
 
     expected = '{"eventType":"sn.user.login","userId":"USER_ID","userTraits":{' \
-                   '"name":"USER_NAME","email":"USER_EMAIL","createdAt":null},"request":{' \
+                   '"name":"USER_NAME","email":"USER_EMAIL","phone":"+1234567890","createdAt":null},"request":{' \
                    '"cid":null,"vid":null,"fp":null,"ip":"127.0.0.1","remoteIp":null,"headers":{' \
                    '"user-agent":"Mozilla/5.0 (iPad; U; CPU OS 3_2_1 like Mac OS X; en-us) ' \
                    'AppleWebKit/531.21.10 (KHTML, like Gecko) Mobile/7B405"},"url":null,"method":null},' \

spec/spec_event_manager.rb

@@ -10,7 +10,7 @@ def initialize
     @timestamp = Time.now.strftime('%Y-%m-%dT%H:%M:%S.%L%Z')
     @rid = '432532'
     @user_id = '1'
-    @user_traits = UserTraits('some user', '[email protected]')
+    @user_traits = UserTraits('some user', '[email protected]', '+1234567890')
     @request = RequestContext()
     @properties = []
   end