SN-1938 Validate user id

Author: Inbal Tako

securenative/models/sdk_event.py

@@ -14,6 +14,9 @@ def __init__(self, event_options, securenative_options):
         if event_options.user_id is None or len(event_options.user_id) <= 0 or event_options.user_id == "":
             raise SecureNativeInvalidOptionsException("Invalid event structure; User Id is missing")
 
+        if event_options.event is None or len(event_options.event.value) <= 0 or event_options.event.value == "":
+            raise SecureNativeInvalidOptionsException("Invalid event structure; Event Type is missing")
+
         if event_options.context is not None:
             self.context = event_options.context
         else:

tests/api_manager_test.py

@@ -49,27 +49,6 @@ def test_track_event(self):
         finally:
             event_manager.stop_event_persist()
 
-    @responses.activate
-    def test_securenative_invalid_options_exception(self):
-        options = SecureNativeOptions(api_key="YOUR_API_KEY", auto_send=True, interval=10,
-                                      api_url="https://api.securenative-stg.com/collector/api/v1")
-
-        properties = {}
-        for i in range(1, 12):
-            properties[i] = i
-
-        responses.add(responses.POST, "https://api.securenative-stg.com/collector/api/v1/track",
-                      json={}, status=200)
-        event_manager = EventManager(options)
-        event_manager.start_event_persist()
-        api_manager = ApiManager(event_manager, options)
-
-        try:
-            with self.assertRaises(SecureNativeInvalidOptionsException):
-                api_manager.track(EventOptions(EventTypes.LOG_IN, "User-ID"))
-        finally:
-            event_manager.stop_event_persist()
-
     @responses.activate
     def test_verify_event(self):
         options = SecureNativeOptions(api_key="YOUR_API_KEY",

tests/sdk_event_test.py

@@ -15,3 +15,10 @@ def test_creating_event_without_user_id_throws(self):
             options = SecureNativeOptions()
 
             SDKEvent(event_options, options)
+
+    def test_creating_event_without_event_type_throws(self):
+        with self.assertRaises(SecureNativeInvalidOptionsException):
+            event_options = EventOptions(None, "1234")
+            options = SecureNativeOptions()
+
+            SDKEvent(event_options, options)

tests/securenative_test.py

@@ -50,9 +50,9 @@ def test_init_sdk_with_api_key_and_get_instance(self):
 
         self.assertEqual(securenative, SecureNative.get_instance())
 
-    def test_init_sdk_with_builder(self):
+    def test_init_sdk_with_options(self):
         SecureNative._flush()
-        options = SecureNativeOptions(api_key="YOUR_API_KEY", auto_send=True, interval=10,
+        options = SecureNativeOptions(api_key="API_KEY", log_level="ERROR", max_events=10,
                                       api_url="https://api.securenative-stg.com/collector/api/v1")
         securenative = SecureNative.init_with_options(options)