Skip to content

Commit d24d670

Browse files
author
Inbal Tako
committed
Fix tests
1 parent 93a4eb2 commit d24d670

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ from securenative.models.user_traits import UserTraits
119119
def track(request):
120120
securenative = SecureNative.get_instance()
121121

122-
context = SecureNative.from_http_request(request)
122+
context = securenative.from_http_request(request)
123123
event_options = EventOptions(event=EventTypes.LOG_IN,
124124
user_id="1234",
125125
user_traits=UserTraits("Your Name", "[email protected]", "+1234567890"),
@@ -143,7 +143,7 @@ from securenative.models.user_traits import UserTraits
143143
def verify(request):
144144
securenative = SecureNative.get_instance()
145145

146-
context = SecureNative.from_http_request(request)
146+
context = securenative.from_http_request(request)
147147
event_options = EventOptions(event=EventTypes.LOG_IN,
148148
user_id="1234",
149149
user_traits=UserTraits("Your Name", "[email protected]", "+1234567890"),

securenative/utils/request_utils.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,25 @@ def get_client_ip_from_request(request, options):
1919
if request.headers[header] is not None:
2020
return request.headers[header]
2121
except Exception:
22-
continue
22+
try:
23+
if request.headers[header] is not None:
24+
return request.headers[header]
25+
except Exception:
26+
continue
2327

2428
try:
2529
x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR')
2630
if x_forwarded_for:
2731
ip = x_forwarded_for.split(',')[-1].strip()
2832
else:
2933
ip = request.META.get('REMOTE_ADDR')
34+
35+
if ip is None or ip == "":
36+
ip = request.environ.get('HTTP_X_FORWARDED_FOR', request.environ.get('REMOTE_ADDR', ""))
37+
3038
return ip
3139
except Exception:
32-
return request.environ.get('HTTP_X_FORWARDED_FOR', request.environ.get('REMOTE_ADDR', ""))
40+
return ""
3341

3442
@staticmethod
3543
def get_remote_ip_from_request(request):

0 commit comments

Comments
 (0)