Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在 SCQL 中实现单方算子 abs #112

Closed
Candicepan opened this issue Jul 21, 2023 · 5 comments · Fixed by #127
Closed

在 SCQL 中实现单方算子 abs #112

Candicepan opened this issue Jul 21, 2023 · 5 comments · Fixed by #127
Assignees
@cs1317
Labels
enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan

Comments

@Candicepan
Copy link
Contributor

此 ISSUE 为 隐语开源共建计划（SecretFlow Open Source Contribution Plan，简称 SF OSCP）第二期任务 ISSUE，欢迎社区开发者参与共建～
若有感兴趣想要认领的任务，但还未报名，辛苦先完成报名进行哈～

任务介绍

  • 任务名称：在 SCQL 中实现单方算子 abs
  • 技术方向：SCQL
  • 任务难度：进阶🌟🌟

详细要求

在 SCQL 中实现单方算子abs，按照《SCQL 单方算子贡献指南》进行逐步贡献操作

能力要求

  • 熟悉 SQL 语法
  • 熟悉 Go 语言
  • 熟悉 SCQL 代码结构

操作说明
@Candicepan Candicepan added enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan labels Jul 21, 2023
@cs1317
Copy link
Contributor

cs1317 commented Aug 7, 2023

cs1317 Give it to me

@cs1317
Copy link
Contributor

cs1317 commented Aug 8, 2023

添加测试用例

image
image

@cs1317
Copy link
Contributor

cs1317 commented Aug 8, 2023

运行测试

go test ./pkg/planner/core/...
image
可以复现 新增单方算子贡献指南中的错误，且错误原因是abs算子未实现

@cs1317
Copy link
Contributor

cs1317 commented Aug 8, 2023

代码中实现abs算子

image
image

@cs1317
Copy link
Contributor

cs1317 commented Aug 8, 2023

再次运行测试，测试通过

image

@cs1317 cs1317 mentioned this issue Aug 8, 2023
Closed
@Candicepan Candicepan linked a pull request Aug 8, 2023 that will close this issue
feat:add single party func abs #125
Closed
This was referenced Aug 8, 2023
Closed
Merged
@Candicepan Candicepan linked a pull request Aug 9, 2023 that will close this issue
feat:add single party func abs #127
Merged
tongke6 pushed a commit that referenced this issue Aug 9, 2023
@cs1317
feat:add single party func abs (#127)
afa69f6 
在SCQL中实现单方算子abs
#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cs1317 cs1317

Labels
enhancement New feature or request OSCP SecretFlow Open Source Contribution Plan
Projects
No open projects
OSCP Phase 2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat:add single party func abs
feat:add single party func abs
2 participants
@Candicepan @cs1317