Crash on fatal exit so that the crash logger can catch the failure.

Author: roxanneskelly

build/patches/crash_on_fatal_error.patch

@@ -0,0 +1,29 @@
+diff --git a/rtc_base/checks.cc b/rtc_base/checks.cc
+index e732a2659d..29baf495e4 100644
+--- a/rtc_base/checks.cc
++++ b/rtc_base/checks.cc
+@@ -69,13 +69,22 @@ RTC_NORETURN void WriteFatalLog(absl::string_view output) {
+   __android_log_print(ANDROID_LOG_ERROR, RTC_LOG_TAG_ANDROID, "%s\n",
+                       output_str.c_str());
+ #endif
++  // write to stdout so that it ends up in the logs.
++  fwrite(output.data(), output.size(), 1, stdout);
+   fflush(stdout);
+   fwrite(output.data(), output.size(), 1, stderr);
+   fflush(stderr);
+ #if defined(WEBRTC_WIN)
+-  DebugBreak();
++//  DebugBreak();
+ #endif
+-  abort();
++  // force a crash so that the crash logger can capture the exception.
++  long* null_ptr;
++  null_ptr = 0;
++  *null_ptr = 0xDEADBEEF;
++  while (true)
++  {
++    _sleep(1);
++  }
+ }
+ 
+ RTC_NORETURN void WriteFatalLog(const char* file,

build/run.py

@@ -187,6 +187,7 @@ def get_depot_tools(source_dir, fetch=False):
         'bug_8759_workaround.patch',
         'msvc-checks-template.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'windows_x86': [
         'add_license_dav1d.patch',
@@ -198,6 +199,7 @@ def get_depot_tools(source_dir, fetch=False):
         'bug_8759_workaround.patch',
         'msvc-checks-template.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'windows_arm64': [
         'add_license_dav1d.patch',
@@ -209,6 +211,7 @@ def get_depot_tools(source_dir, fetch=False):
         'bug_8759_workaround.patch',
         'msvc-checks-template.patch'
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'macos_x86_64': [
         'add_license_dav1d.patch',
@@ -217,6 +220,7 @@ def get_depot_tools(source_dir, fetch=False):
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'macos_arm64': [
         'add_license_dav1d.patch',
@@ -225,6 +229,7 @@ def get_depot_tools(source_dir, fetch=False):
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ios': [
         'add_license_dav1d.patch',
@@ -233,6 +238,7 @@ def get_depot_tools(source_dir, fetch=False):
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'android': [
         'add_license_dav1d.patch',
@@ -241,69 +247,79 @@ def get_depot_tools(source_dir, fetch=False):
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'android_prefixed': [
         'add_license_dav1d.patch',
         'android_webrtc_version.patch',
         'fix_mocks.patch',
         'jni_prefix.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'raspberry-pi-os_armv6': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'raspberry-pi-os_armv7': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'raspberry-pi-os_armv8': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ubuntu-18.04_armv8': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ubuntu-20.04_armv8': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ubuntu-18.04_x86_64': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ubuntu-20.04_x86_64': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
     'ubuntu-22.04_x86_64': [
         'add_license_dav1d.patch',
         'fix_mocks.patch',
         'upsample-to-48khz-for-echo-cancellation-for-now.patch',
         'bug_8759_workaround.patch',
         'disable_mute_of_audio_processing.patch',
+        'crash_on_fatal_error.patch',
     ],
 }