Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerResponse must have finished property #128

Open
lastmjs opened this issue Jan 25, 2024 · 0 comments
Open

ServerResponse must have finished property #128

lastmjs opened this issue Jan 25, 2024 · 0 comments

Comments

@lastmjs
Copy link

lastmjs commented Jan 25, 2024

This bug was absolutely crazy to track down. Essentially ServerResponse should have the finished = false; set at least on instantiation. When trying to get an Express.js application to work, some of the streaming code looks for that finished property. If it is not there, then it thinks that the read stream is instantly finished and sets a macro task for execution. This terminates the read stream right away and breaks the functionality. Simply adding that property to ServerResponse fixes the issue for me.

We should probably ensure that these Node data structures have all original properties at least initialized, even if they are not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant