Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuickJS to latest, major bugs #125

Open
lastmjs opened this issue Jan 17, 2024 · 3 comments
Open

Update QuickJS to latest, major bugs #125

lastmjs opened this issue Jan 17, 2024 · 3 comments

Comments

@lastmjs
Copy link

lastmjs commented Jan 17, 2024

From our project's property testing we have recently found two major bugs in QuickJS that have since been fixed.

JSON.parse bug: bellard/quickjs#206
BigUint64Array bug: bellard/quickjs#202

Could we get wasmedge-quickjs to update to the absolute latest QuickJS version? Now that we're using wasmedge-quickjs we would like to be on the latest QuickJS, and we have to compile our own custom QuickJS from https://github.com/second-state/quickjs-wasi/tree/master because we can't have SIMD support.

@L-jasmine
Copy link
Collaborator

Ok, I will update https://github.com/second-state/quickjs-wasi. How do you disable SIMD when build quickjs-wasi?

@lastmjs
Copy link
Author

lastmjs commented Jan 25, 2024

To disable I just remove the first option from here and run the file: https://github.com/second-state/quickjs-wasi/blob/master/lib/build_lib.sh#L2

@L-jasmine
Copy link
Collaborator

@lastmjs second-state/quickjs-wasi#5 quickjs-wasi has been updated.
But, you need to clone the master branch of wasi-libc as the sys-root to compile successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants