Skip to content

Add CBOR fields (cborfields.py, cborpacket.py) and tests#4958

Merged
polybassa merged 2 commits intosecdev:masterfrom
polybassa:create-cbor-fields-2
Apr 12, 2026
Merged

Add CBOR fields (cborfields.py, cborpacket.py) and tests#4958
polybassa merged 2 commits intosecdev:masterfrom
polybassa:create-cbor-fields-2

Conversation

@polybassa
Copy link
Copy Markdown
Contributor

@polybassa polybassa commented Mar 30, 2026 •
edited
Loading

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using tox)
  • If the PR is still not finished, please create a Draft Pull Request

fixes #xxx

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.39644% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.31%. Comparing base (f4a2ca4) to head (3011b60).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
scapy/cbor/cborfields.py 77.85% 95 Missing ⚠️
scapy/cborpacket.py 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #4958    +/-   ##
========================================
  Coverage   80.30%   80.31%            
========================================
  Files         379      381     +2     
  Lines       93107    93556   +449     
========================================
+ Hits        74769    75136   +367     
- Misses      18338    18420    +82
Files with missing lines Coverage Δ
scapy/cbor/__init__.py 100.00% <100.00%> (ø)
scapy/cborpacket.py 89.47% <89.47%> (ø)
scapy/cbor/cborfields.py 77.85% <77.85%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gpotter2
gpotter2 reviewed Mar 30, 2026
View reviewed changes
Comment thread scapy/cbor/cborfields.py
@polybassa polybassa requested a review from gpotter2 April 2, 2026 12:15
@polybassa
Copy link
Copy Markdown
Contributor Author

polybassa commented Apr 10, 2026

@gpotter2 are you OK with a merge?

@gpotter2
Copy link
Copy Markdown
Member

gpotter2 commented Apr 11, 2026

Yeah, this LGTM.

@gpotter2
Copy link
Copy Markdown
Member

gpotter2 commented Apr 11, 2026

What we should do afterwards is build stuff on it to make sure it works. Like the PRs.

I also would like to play with CTAP

@polybassa polybassa merged commit c4064de into secdev:master Apr 12, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpotter2 gpotter2 Awaiting requested review from gpotter2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polybassa @gpotter2