Fix xdg folder permission check for cases when privileges were dropped #4619

Civil · 2024-12-25T23:05:19Z

If privileges for scapy were dropped, but username remain unchanged, path.exist() would trigger an exception. Fix that by moving whole if statement under try-except.

Checklist:

If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
I squashed commits belonging together
I added unit tests or explained why they are not relevant
Tests are not relevant because it is extremely hard to write a proper test for that behaviour.
I executed the regression tests (using cd test && ./run_tests or tox)
If the PR is still not finished, please create a Draft Pull Request

Fixes #4618

If privileges for scapy were dropped, but username remain unchanged, path.exist() would trigger an exception. Fix that by moving whole if statement under try-except. Fixes secdev#4618

codecov · 2024-12-25T23:17:35Z

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (cb4a95b) to head (83adf2b).

Files with missing lines	Patch %	Lines
scapy/main.py	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4619      +/-   ##
==========================================
- Coverage   81.31%   78.71%   -2.61%     
==========================================
  Files         359      334      -25     
  Lines       86047    80848    -5199     
==========================================
- Hits        69971    63641    -6330     
- Misses      16076    17207    +1131

Files with missing lines	Coverage Δ
scapy/main.py	`69.13% <50.00%> (-0.87%)`	⬇️

... and 280 files with indirect coverage changes

Fix xdg folder permission check for cases when privileges were dropped

83adf2b

If privileges for scapy were dropped, but username remain unchanged, path.exist() would trigger an exception. Fix that by moving whole if statement under try-except. Fixes secdev#4618

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix xdg folder permission check for cases when privileges were dropped #4619

Fix xdg folder permission check for cases when privileges were dropped #4619

Civil commented Dec 25, 2024

codecov bot commented Dec 25, 2024 •

edited

Loading

Fix xdg folder permission check for cases when privileges were dropped #4619

Are you sure you want to change the base?

Fix xdg folder permission check for cases when privileges were dropped #4619

Conversation

Civil commented Dec 25, 2024

codecov bot commented Dec 25, 2024 • edited Loading

Codecov Report

codecov bot commented Dec 25, 2024 •

edited

Loading