Make AllowMockObjectsWithoutExpectations usable on test methods

sebastianbergmann · sebastianbergmann · commit 4e76df1464ee · 2025-12-13T11:34:16.000+01:00
diff --git a/ChangeLog-12.5.md b/ChangeLog-12.5.md
@@ -4,6 +4,10 @@ All notable changes of the PHPUnit 12.5 release series are documented in this fi
 
 ## [12.5.4] - 2025-MM-DD
 
+### Changed
+
+* The `#[AllowMockObjectsWithoutExpectations]` attribute can now be used on the method level
+
 ### Fixed
 
 * [#6446](https://github.com/sebastianbergmann/phpunit/issues/6446): Test runner crashes with `Timer::start() has to be called before Timer::stop()`
diff --git a/src/Framework/Attributes/AllowMockObjectsWithoutExpectations.php b/src/Framework/Attributes/AllowMockObjectsWithoutExpectations.php
@@ -16,7 +16,7 @@
  *
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  */
-#[Attribute(Attribute::TARGET_CLASS)]
+#[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD)]
 final readonly class AllowMockObjectsWithoutExpectations
 {
 }
diff --git a/src/Framework/TestCase.php b/src/Framework/TestCase.php
@@ -2454,6 +2454,11 @@ private function stopErrorLogCapture(): void
         $this->previousErrorLogTarget = false;
     }
 
+    private function allowsMockObjectsWithoutExpectations(): bool
+    {
+        return MetadataRegistry::parser()->forClassAndMethod(static::class, $this->methodName)->isAllowMockObjectsWithoutExpectations()->isNotEmpty();
+    }
+
     /**
      * Returns a builder object to create test stubs using a fluent interface.
      *
@@ -2542,11 +2547,6 @@ final protected static function createConfiguredStub(string $type, array $config
         return $o;
     }
 
-    private static function allowsMockObjectsWithoutExpectations(): bool
-    {
-        return MetadataRegistry::parser()->forClass(static::class)->isAllowMockObjectsWithoutExpectations()->isNotEmpty();
-    }
-
     private static function generateReturnValuesForTestDoubles(): bool
     {
         return MetadataRegistry::parser()->forClass(static::class)->isDisableReturnValueGenerationForTestDoubles()->isEmpty();
diff --git a/src/Metadata/Metadata.php b/src/Metadata/Metadata.php
@@ -37,11 +37,16 @@ public static function afterClass(int $priority): AfterClass
         return new AfterClass(self::METHOD_LEVEL, $priority);
     }
 
-    public static function allowMockObjectsWithoutExpectations(): AllowMockObjectsWithoutExpectations
+    public static function allowMockObjectsWithoutExpectationsOnClass(): AllowMockObjectsWithoutExpectations
     {
         return new AllowMockObjectsWithoutExpectations(self::CLASS_LEVEL);
     }
 
+    public static function allowMockObjectsWithoutExpectationsOnMethod(): AllowMockObjectsWithoutExpectations
+    {
+        return new AllowMockObjectsWithoutExpectations(self::METHOD_LEVEL);
+    }
+
     public static function backupGlobalsOnClass(bool $enabled): BackupGlobals
     {
         return new BackupGlobals(self::CLASS_LEVEL, $enabled);
diff --git a/src/Metadata/Parser/AttributeParser.php b/src/Metadata/Parser/AttributeParser.php
@@ -143,7 +143,7 @@ public function forClass(string $className): MetadataCollection
                 case AllowMockObjectsWithoutExpectations::class:
                     assert($attributeInstance instanceof AllowMockObjectsWithoutExpectations);
 
-                    $result[] = Metadata::allowMockObjectsWithoutExpectations();
+                    $result[] = Metadata::allowMockObjectsWithoutExpectationsOnClass();
 
                     break;
 
@@ -566,6 +566,13 @@ public function forMethod(string $className, string $methodName): MetadataCollec
 
                     break;
 
+                case AllowMockObjectsWithoutExpectations::class:
+                    assert($attributeInstance instanceof AllowMockObjectsWithoutExpectations);
+
+                    $result[] = Metadata::allowMockObjectsWithoutExpectationsOnMethod();
+
+                    break;
+
                 case BackupGlobals::class:
                     assert($attributeInstance instanceof BackupGlobals);
 
diff --git a/tests/_files/Metadata/Attribute/tests/AllowMockObjectsWithoutExpectationsOnClassTest.php b/tests/_files/Metadata/Attribute/tests/AllowMockObjectsWithoutExpectationsOnClassTest.php
@@ -13,7 +13,7 @@
 use PHPUnit\Framework\TestCase;
 
 #[AllowMockObjectsWithoutExpectations]
-final class AllowMockObjectsWithoutExpectationsTest extends TestCase
+final class AllowMockObjectsWithoutExpectationsOnClassTest extends TestCase
 {
     public function testOne(): void
     {
diff --git a/tests/_files/Metadata/Attribute/tests/AllowMockObjectsWithoutExpectationsOnMethodTest.php b/tests/_files/Metadata/Attribute/tests/AllowMockObjectsWithoutExpectationsOnMethodTest.php
@@ -0,0 +1,21 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\Metadata\Attribute;
+
+use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
+use PHPUnit\Framework\TestCase;
+
+final class AllowMockObjectsWithoutExpectationsOnMethodTest extends TestCase
+{
+    #[AllowMockObjectsWithoutExpectations]
+    public function testOne(): void
+    {
+    }
+}
diff --git a/tests/end-to-end/event/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest.php b/tests/end-to-end/event/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest.php
@@ -14,7 +14,7 @@
 use PHPUnit\TestFixture\Event\Example;
 
 #[AllowMockObjectsWithoutExpectations]
-final class CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest extends TestCase
+final class CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest extends TestCase
 {
     public function testOne(): void
     {
diff --git a/tests/end-to-end/event/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest.php b/tests/end-to-end/event/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest.php
@@ -0,0 +1,25 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace TestFixture\PHPUnit\Event;
+
+use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
+use PHPUnit\Framework\TestCase;
+use PHPUnit\TestFixture\Event\Example;
+
+final class CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest extends TestCase
+{
+    #[AllowMockObjectsWithoutExpectations]
+    public function testOne(): void
+    {
+        $this->createMock(Example::class);
+
+        $this->assertTrue(true);
+    }
+}
diff --git a/tests/end-to-end/event/mock-object-created-with-createMock-without-expectations-and-AllowMockObjectsWithoutExpectations-on-test-class.phpt b/tests/end-to-end/event/mock-object-created-with-createMock-without-expectations-and-AllowMockObjectsWithoutExpectations-on-test-class.phpt
@@ -1,13 +1,13 @@
 --TEST--
-The right events are emitted in the right order for a test that creates a mock object using createMock() and does not configure expectations but AllowMockObjectsWithoutExpectations is used
+The right events are emitted in the right order for a test that creates a mock object using createMock() and does not configure expectations but AllowMockObjectsWithoutExpectations is used on test class
 --FILE--
 <?php declare(strict_types=1);
 $_SERVER['argv'][] = '--do-not-cache-result';
 $_SERVER['argv'][] = '--no-configuration';
 $_SERVER['argv'][] = '--bootstrap';
 $_SERVER['argv'][] = __DIR__ . '/_files/Example.php';
 $_SERVER['argv'][] = '--debug';
-$_SERVER['argv'][] = __DIR__ . '/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest.php';
+$_SERVER['argv'][] = __DIR__ . '/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest.php';
 
 require __DIR__ . '/../../bootstrap.php';
 
@@ -21,13 +21,13 @@ Test Suite Loaded (1 test)
 Test Runner Started
 Test Suite Sorted
 Test Runner Execution Started (1 test)
-Test Suite Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest, 1 test)
-Test Preparation Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest::testOne)
-Test Prepared (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest::testOne)
+Test Suite Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest, 1 test)
+Test Preparation Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest::testOne)
+Test Prepared (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest::testOne)
 Mock Object Created (PHPUnit\TestFixture\Event\Example)
-Test Passed (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest::testOne)
-Test Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest::testOne)
-Test Suite Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest, 1 test)
+Test Passed (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest::testOne)
+Test Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest::testOne)
+Test Suite Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest, 1 test)
 Test Runner Execution Finished
 Test Runner Finished
 PHPUnit Finished (Shell Exit Code: 0)
diff --git a/tests/end-to-end/event/mock-object-created-with-createMock-without-expectations-and-AllowMockObjectsWithoutExpectations-on-test-method.phpt b/tests/end-to-end/event/mock-object-created-with-createMock-without-expectations-and-AllowMockObjectsWithoutExpectations-on-test-method.phpt
@@ -0,0 +1,33 @@
+--TEST--
+The right events are emitted in the right order for a test that creates a mock object using createMock() and does not configure expectations but AllowMockObjectsWithoutExpectations is used on test method
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = '--bootstrap';
+$_SERVER['argv'][] = __DIR__ . '/_files/Example.php';
+$_SERVER['argv'][] = '--debug';
+$_SERVER['argv'][] = __DIR__ . '/_files/CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest.php';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit Started (PHPUnit %s using %s)
+Test Runner Configured
+Bootstrap Finished (%sExample.php)
+Event Facade Sealed
+Test Suite Loaded (1 test)
+Test Runner Started
+Test Suite Sorted
+Test Runner Execution Started (1 test)
+Test Suite Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest, 1 test)
+Test Preparation Started (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest::testOne)
+Test Prepared (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest::testOne)
+Mock Object Created (PHPUnit\TestFixture\Event\Example)
+Test Passed (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest::testOne)
+Test Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest::testOne)
+Test Suite Finished (TestFixture\PHPUnit\Event\CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnMethodTest, 1 test)
+Test Runner Execution Finished
+Test Runner Finished
+PHPUnit Finished (Shell Exit Code: 0)
diff --git a/tests/unit/Metadata/MetadataCollectionTest.php b/tests/unit/Metadata/MetadataCollectionTest.php
@@ -585,7 +585,7 @@ private function collectionWithOneOfEach(): MetadataCollection
             [
                 Metadata::afterClass(0),
                 Metadata::after(0),
-                Metadata::AllowMockObjectsWithoutExpectations(),
+                Metadata::allowMockObjectsWithoutExpectationsOnClass(),
                 Metadata::backupGlobalsOnClass(true),
                 Metadata::backupStaticPropertiesOnClass(true),
                 Metadata::beforeClass(0),
diff --git a/tests/unit/Metadata/MetadataTest.php b/tests/unit/Metadata/MetadataTest.php
@@ -160,7 +160,7 @@ public function testCanBeAfterClass(): void
 
     public function testCanBeAllowMockObjectsWithoutExpectations(): void
     {
-        $metadata = Metadata::allowMockObjectsWithoutExpectations();
+        $metadata = Metadata::allowMockObjectsWithoutExpectationsOnClass();
 
         $this->assertFalse($metadata->isAfter());
         $this->assertFalse($metadata->isAfterClass());
diff --git a/tests/unit/Metadata/Parser/AttributeParserTestCase.php b/tests/unit/Metadata/Parser/AttributeParserTestCase.php
@@ -24,7 +24,8 @@
 use PHPUnit\Metadata\Version\ComparisonRequirement;
 use PHPUnit\Metadata\Version\ConstraintRequirement;
 use PHPUnit\Metadata\WithEnvironmentVariable;
-use PHPUnit\TestFixture\Metadata\Attribute\AllowMockObjectsWithoutExpectationsTest;
+use PHPUnit\TestFixture\Metadata\Attribute\AllowMockObjectsWithoutExpectationsOnClassTest;
+use PHPUnit\TestFixture\Metadata\Attribute\AllowMockObjectsWithoutExpectationsOnMethodTest;
 use PHPUnit\TestFixture\Metadata\Attribute\AnotherTest;
 use PHPUnit\TestFixture\Metadata\Attribute\BackupGlobalsTest;
 use PHPUnit\TestFixture\Metadata\Attribute\BackupStaticPropertiesTest;
@@ -71,7 +72,7 @@ abstract class AttributeParserTestCase extends TestCase
     #[TestDox('Parses #[AllowMockObjectsWithoutExpectations] attribute on class')]
     public function test_parses_AllowMockObjectsWithoutExpectations_attribute_on_class(): void
     {
-        $metadata = $this->parser()->forClass(AllowMockObjectsWithoutExpectationsTest::class)->isAllowMockObjectsWithoutExpectations();
+        $metadata = $this->parser()->forClass(AllowMockObjectsWithoutExpectationsOnClassTest::class)->isAllowMockObjectsWithoutExpectations();
 
         $this->assertCount(1, $metadata);
         $this->assertTrue($metadata->asArray()[0]->isAllowMockObjectsWithoutExpectations());
@@ -568,6 +569,15 @@ public function test_parses_AfterClass_attribute_on_method(): void
         $this->assertTrue($metadata->asArray()[0]->isAfterClass());
     }
 
+    #[TestDox('Parses #[AllowMockObjectsWithoutExpectations] attribute on method')]
+    public function test_parses_AllowMockObjectsWithoutExpectations_attribute_on_method(): void
+    {
+        $metadata = $this->parser()->forMethod(AllowMockObjectsWithoutExpectationsOnMethodTest::class, 'testOne')->isAllowMockObjectsWithoutExpectations();
+
+        $this->assertCount(1, $metadata);
+        $this->assertTrue($metadata->asArray()[0]->isAllowMockObjectsWithoutExpectations());
+    }
+
     #[TestDox('Parses #[BackupGlobals] attribute on method')]
     public function test_parses_BackupGlobals_attribute_on_method(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*`
`17`	`17`	`* @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit`
`18`	`18`	`*/`
`19`		`-#[Attribute(Attribute::TARGET_CLASS)]`
	`19`	`+#[Attribute(Attribute::TARGET_CLASS \| Attribute::TARGET_METHOD)]`
`20`	`20`	`final readonly class AllowMockObjectsWithoutExpectations`
`21`	`21`	`{`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2454,6 +2454,11 @@ private function stopErrorLogCapture(): void`
`2454`	`2454`	`$this->previousErrorLogTarget = false;`
`2455`	`2455`	`}`
`2456`	`2456`
	`2457`	`+ private function allowsMockObjectsWithoutExpectations(): bool`
	`2458`	`+ {`
	`2459`	`+ return MetadataRegistry::parser()->forClassAndMethod(static::class, $this->methodName)->isAllowMockObjectsWithoutExpectations()->isNotEmpty();`
	`2460`	`+ }`
	`2461`	`+`
`2457`	`2462`	`/**`
`2458`	`2463`	`* Returns a builder object to create test stubs using a fluent interface.`
`2459`	`2464`	`*`
`@@ -2542,11 +2547,6 @@ final protected static function createConfiguredStub(string $type, array $config`
`2542`	`2547`	`return $o;`
`2543`	`2548`	`}`
`2544`	`2549`
`2545`		`- private static function allowsMockObjectsWithoutExpectations(): bool`
`2546`		`- {`
`2547`		`- return MetadataRegistry::parser()->forClass(static::class)->isAllowMockObjectsWithoutExpectations()->isNotEmpty();`
`2548`		`- }`
`2549`		`-`
`2550`	`2550`	`private static function generateReturnValuesForTestDoubles(): bool`
`2551`	`2551`	`{`
`2552`	`2552`	`return MetadataRegistry::parser()->forClass(static::class)->isDisableReturnValueGenerationForTestDoubles()->isEmpty();`
Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,16 @@ public static function afterClass(int $priority): AfterClass`
`37`	`37`	`return new AfterClass(self::METHOD_LEVEL, $priority);`
`38`	`38`	`}`
`39`	`39`
`40`		`- public static function allowMockObjectsWithoutExpectations(): AllowMockObjectsWithoutExpectations`
	`40`	`+ public static function allowMockObjectsWithoutExpectationsOnClass(): AllowMockObjectsWithoutExpectations`
`41`	`41`	`{`
`42`	`42`	`return new AllowMockObjectsWithoutExpectations(self::CLASS_LEVEL);`
`43`	`43`	`}`
`44`	`44`
	`45`	`+ public static function allowMockObjectsWithoutExpectationsOnMethod(): AllowMockObjectsWithoutExpectations`
	`46`	`+ {`
	`47`	`+ return new AllowMockObjectsWithoutExpectations(self::METHOD_LEVEL);`
	`48`	`+ }`
	`49`	`+`
`45`	`50`	`public static function backupGlobalsOnClass(bool $enabled): BackupGlobals`
`46`	`51`	`{`
`47`	`52`	`return new BackupGlobals(self::CLASS_LEVEL, $enabled);`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`use PHPUnit\Framework\TestCase;`
`14`	`14`
`15`	`15`	`#[AllowMockObjectsWithoutExpectations]`
`16`		`-final class AllowMockObjectsWithoutExpectationsTest extends TestCase`
	`16`	`+final class AllowMockObjectsWithoutExpectationsOnClassTest extends TestCase`
`17`	`17`	`{`
`18`	`18`	`public function testOne(): void`
`19`	`19`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`use PHPUnit\TestFixture\Event\Example;`
`15`	`15`
`16`	`16`	`#[AllowMockObjectsWithoutExpectations]`
`17`		`-final class CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsTest extends TestCase`
	`17`	`+final class CreateMockWithoutExpectationsAndAllowMockObjectsWithoutExpectationsOnClassTest extends TestCase`
`18`	`18`	`{`
`19`	`19`	`public function testOne(): void`
`20`	`20`	`{`