Skip to content

Commit 1f41778

Browse files
Set signature attribute on the <line> element (and reorder attributes to match XSD)
1 parent c8ba7a1 commit 1f41778

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

src/Report/Clover.php

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
109109
'ccn' => $method['ccn'],
110110
'count' => $methodCount,
111111
'type' => 'method',
112+
'signature' => $method['signature'],
112113
'visibility' => $method['visibility'],
113114
];
114115
}
@@ -149,15 +150,20 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
149150
$xmlLine->setAttribute('num', (string) $line);
150151
$xmlLine->setAttribute('type', $data['type']);
151152

152-
if (isset($data['visibility'])) {
153-
$xmlLine->setAttribute('visibility', $data['visibility']);
154-
}
155-
156153
if (isset($data['ccn'])) {
157154
$xmlLine->setAttribute('complexity', (string) $data['ccn']);
158155
}
159156

160157
$xmlLine->setAttribute('count', (string) $data['count']);
158+
159+
if (isset($data['signature'])) {
160+
$xmlLine->setAttribute('signature', $data['signature']);
161+
}
162+
163+
if (isset($data['visibility'])) {
164+
$xmlLine->setAttribute('visibility', $data['visibility']);
165+
}
166+
161167
$xmlFile->appendChild($xmlLine);
162168
}
163169

tests/_files/BankAccount-clover-line.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
<class name="BankAccount">
1010
<metrics complexity="5" elements="12" coveredelements="8" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="5" methods="4" coveredmethods="3"/>
1111
</class>
12-
<line num="6" type="method" visibility="public" complexity="1" count="2"/>
12+
<line num="6" type="method" complexity="1" count="2" signature="getBalance()" visibility="public"/>
1313
<line num="8" type="stmt" count="2"/>
14-
<line num="11" type="method" visibility="protected" complexity="2" count="0"/>
14+
<line num="11" type="method" complexity="2" count="0" signature="setBalance($balance)" visibility="protected"/>
1515
<line num="13" type="stmt" count="0"/>
1616
<line num="14" type="stmt" count="0"/>
1717
<line num="16" type="stmt" count="0"/>
18-
<line num="20" type="method" visibility="public" complexity="1" count="2"/>
18+
<line num="20" type="method" complexity="1" count="2" signature="depositMoney($balance)" visibility="public"/>
1919
<line num="22" type="stmt" count="2"/>
2020
<line num="24" type="stmt" count="1"/>
21-
<line num="27" type="method" visibility="public" complexity="1" count="2"/>
21+
<line num="27" type="method" complexity="1" count="2" signature="withdrawMoney($balance)" visibility="public"/>
2222
<line num="29" type="stmt" count="2"/>
2323
<line num="31" type="stmt" count="1"/>
2424
</file>

tests/_files/BankAccount-clover-path.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
<class name="BankAccount">
1010
<metrics complexity="5" elements="19" coveredelements="11" conditionals="7" coveredconditionals="3" statements="8" coveredstatements="5" methods="4" coveredmethods="3"/>
1111
</class>
12-
<line num="6" type="method" visibility="public" complexity="1" count="2"/>
12+
<line num="6" type="method" complexity="1" count="2" signature="getBalance()" visibility="public"/>
1313
<line num="8" type="stmt" count="2"/>
14-
<line num="11" type="method" visibility="protected" complexity="2" count="0"/>
14+
<line num="11" type="method" complexity="2" count="0" signature="setBalance($balance)" visibility="protected"/>
1515
<line num="13" type="stmt" count="0"/>
1616
<line num="14" type="stmt" count="0"/>
1717
<line num="16" type="stmt" count="0"/>
18-
<line num="20" type="method" visibility="public" complexity="1" count="2"/>
18+
<line num="20" type="method" complexity="1" count="2" signature="depositMoney($balance)" visibility="public"/>
1919
<line num="22" type="stmt" count="2"/>
2020
<line num="24" type="stmt" count="1"/>
21-
<line num="27" type="method" visibility="public" complexity="1" count="2"/>
21+
<line num="27" type="method" complexity="1" count="2" signature="withdrawMoney($balance)" visibility="public"/>
2222
<line num="29" type="stmt" count="2"/>
2323
<line num="31" type="stmt" count="1"/>
2424
</file>

tests/_files/class-with-anonymous-function-clover.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<class name="CoveredClassWithAnonymousFunctionInStaticMethod">
1010
<metrics complexity="1" elements="9" coveredelements="9" conditionals="0" coveredconditionals="0" statements="8" coveredstatements="8" methods="1" coveredmethods="1"/>
1111
</class>
12-
<line num="5" type="method" visibility="public" complexity="1" count="1"/>
12+
<line num="5" type="method" complexity="1" count="1" signature="runAnonymous()" visibility="public"/>
1313
<line num="7" type="stmt" count="1"/>
1414
<line num="9" type="stmt" count="1"/>
1515
<line num="10" type="stmt" count="1"/>

0 commit comments

Comments
 (0)