Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No Link" does not get translated #246

Open
dgsiegel opened this issue Dec 7, 2022 · 0 comments
Open

"No Link" does not get translated #246

dgsiegel opened this issue Dec 7, 2022 · 0 comments

Comments

@dgsiegel
Copy link

dgsiegel commented Dec 7, 2022

The string '(No link)' gets defined here: https://github.com/sebastian-lenz/craft-linkfield/blob/main/src/models/LinkType.php#L113

I was hoping that it will get translated in the linkfield twig template for the select field. But looking at the twig code, I can't find any translation in there. However, as you already added a few translated strings, replacing that line with

return Craft::t('typedlinkfield', '(No link)');

might be the easiest solution.

Interestingly you do translate all other display groups: https://github.com/sebastian-lenz/craft-linkfield/blob/main/src/models/LinkType.php#L103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant