Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing searching words #98

Open
Simkav opened this issue Mar 13, 2023 · 4 comments
Open

Refreshing searching words #98

Simkav opened this issue Mar 13, 2023 · 4 comments
Labels
enhancement New feature or request review Needs further consideration

Comments

@Simkav
Copy link

Simkav commented Mar 13, 2023

Hello, thank you for work, very helpful extension

I'm see a strange behavior, if i change google query it can be 3 differents consequences

  1. Words will refresh
  2. Words not refresh but button for refresh will be avaliable
  3. Words not refresh and button for refresh will not be avaliable(Offten when remove some words froom google query without adding new words)

It will be perfect if will be settings to auto refresh searching words by change google query.

Best regards

@ator-dev ator-dev added bug Something isn't working question Further information is requested labels Mar 13, 2023
@ator-dev
Copy link
Member

ator-dev commented Mar 13, 2023

Hi Simkav, thank you for filing an issue. This is a very important aspect of the extension so it's great to know what needs improving.

  1. I am confused by this - words should never refresh automatically. Could you describe what happens in this case please?
  2. This is intended behaviour but I am aware that it's cumbersome.
  3. This is intended behaviour, since I thought refreshing would not be necessary if words had been removed only. However, for consistency I could make it equivalent to (2).

As to your last point, I agree entirely that there should be a setting for auto-refresh.

Thanks for bringing this to my attention (:

@Simkav
Copy link
Author

Simkav commented Mar 13, 2023

Hi Simkav, thank you for filing an issue. This is a very important aspect of the extension so it's great to know what needs improving.

  1. I am confused by this - words should never refresh automatically. Could you describe what happens in this case please?
  2. This is intended behaviour but I am aware that it's cumbersome.
  3. This is intended behaviour, since I thought refreshing would not be necessary if words had been removed only. However, for consistency I could make it equivalent to (2).

As to your last point, I agree entirely that there should be a setting for auto-refresh.

Thanks for bringing this to my attention (:

Hi again, rn trying to reproduce variant 1(auto-refresh) and can't do it during 10 min :), maybe it seemed to me
I'm will continue use extension, and get you to know if meet this behavior again

Best regards

@ator-dev
Copy link
Member

ator-dev commented Mar 13, 2023

Thank you for the effort (:
For now I will assume it just seemed to refresh, but will look out for it too.

I have updated the extension to v1.13, which eliminates variant 3. I have noticed a small bug that it doesn't appear when entering keywords to Mark My Search manually, but this will be fixed in the next patch. now patched

I will think about ways to make this behaviour more friendly, so you can have automatic refreshing. The main problem is that you might not want your keywords to be suddenly overwritten by a 'detected search'. Updates will be posted here.

@ator-dev ator-dev added enhancement New feature or request review Needs further consideration and removed bug Something isn't working question Further information is requested labels Mar 13, 2023
@ator-dev
Copy link
Member

ator-dev commented Mar 14, 2023

@Simkav quick note, you can assign a shortcut (e.g. Alt+R) to "Replace keywords with detected search keywords". Change extension shortcuts as follows:

  • Firefox: about:addons -> Cog icon -> Manage Extension Shortcuts
  • Chrome / other: chrome://extensions/shortcuts

Then, press your shortcut as a quick way to click the 'reload' button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review Needs further consideration
Projects
None yet
Development

No branches or pull requests

2 participants