Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Global keyword highlighting #73

Open
ator-dev opened this issue Dec 7, 2022 · 1 comment
Open

[Feature Request] Global keyword highlighting #73

ator-dev opened this issue Dec 7, 2022 · 1 comment
Labels
enhancement New feature or request plugin Will be actioned in a separate 'plugin' add-on

Comments

@ator-dev
Copy link
Member

ator-dev commented Dec 7, 2022

[User-submitted request via uninstall form]

I need an option to get my terms highlighted on every page, in every new tab, without need to create a new list every time.

This is an interesting request since I have seen this sentiment mentioned before, both in reviews of past and existing extensions. Although MMS is built on the premise of separate keyword lists per tab (which may be copied into new tabs as appropriate), it could be modified to allow for a globally-applied list. A large subset of users may benefit from this use case, wanting a convenient way to search through everything they already have open.

This could be implemented by directly storing a 'global' list which can overridden by dedicated tab lists, or a functionally similar approach in which a specified list is copied into (and likely updated across) each other tab. MMS began with a concept of shared lists, the evidence of which exists in legacy code and variable names in the backend, but this is unlikely to be a useful approach to revive.

@ator-dev ator-dev added the enhancement New feature or request label Dec 7, 2022
@ator-dev ator-dev changed the title [Feature Request] Global term highlighting [Feature Request] Global keyword highlighting Dec 7, 2022
@ator-dev
Copy link
Member Author

ator-dev commented Mar 7, 2023

[User-submitted request via review]

Sometimes I need to maintain the on-page search-bar (and the same keywords) to search in different tabs. But the on-page search-bar did not automatic show-up when I select another tab. I know Alt-Shift-M can force it to show-up, but the previous keywords would be lost in this situation. Could you make a option to maintain the on-page search-bar (and the previous keywords) in cross-tab searching?

I still plan to implement this, especially given the continuing interest. However, on rethinking this I have a different idea about how it could work. Mark My Search is already quite feature-packed, and I have been glad to see the codebase's complexity stabilising over the last few months. Perhaps this would be better implemented as an add-on 'plugin'?

This add-on would provide its own context menu item and popup UI, in which keywords could be entered. Every time the user visits a tab, these 'global' keywords would be sent to MMS for highlighting on that page in a 'shadowing' mode: the page would grey out the keyword bar if present, and insert a new one below it containing the global keywords. Any existing highlighting would be replaced until the global search is over.

@ator-dev ator-dev added planned Will be actioned plugin Will be actioned in a separate 'plugin' add-on labels Mar 8, 2023
@ator-dev ator-dev removed the planned Will be actioned label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Will be actioned in a separate 'plugin' add-on
Projects
Status: Concept
Development

No branches or pull requests

1 participant