Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically turns on on Google Translate #158

Open
Marin-Kitagawa opened this issue May 15, 2024 · 3 comments
Open

Automatically turns on on Google Translate #158

Marin-Kitagawa opened this issue May 15, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request planned Will be actioned

Comments

@Marin-Kitagawa
Copy link

Whatever I type in Google Translate is captured by this extension. This is just annoying. I quit the toolbar the first time but it reappeared the next time I typed or changed anything in the editor. See the video below.
screen-recorder-wed-may-15-2024-20-20-20.webm

@ator-dev
Copy link
Member

Hi, sorry for the inconvenience. I really appreciate the issue you raised yesterday, I'm just still writing my reply to it as it covers a few areas!

The popup contains the setting you need. If you don't know how to get to that, it's in the Mark My Search icon on the browser toolbar:
image
(It may be hidden under the Extensions puzzle-piece, also in the toolbar.)

Just add the problematic site to "Sites to Not Detect As Search Engines", as follows:

image

@Marin-Kitagawa
Copy link
Author

Oh, thanks. Will try that. It will be easier to add a button in the toolbar to add the site to the ignore list instead of manually adding it to the ignore list. I wasn't aware of the tab at the bottom. Thanks for that. Will look into it. By the way, does it support regular expressions?

@ator-dev
Copy link
Member

ator-dev commented May 15, 2024

No worries. I will label this as a feature request, as I agree that this isn't ideal (it's not very discoverable, and the fact that websites like Google Translate are detected as "search engines" by default isn't good).

does it support regular expressions?

Currently, both lists support domain names, optionally followed by paths. Both the domain name and path can contain wildcards. That means that you can add a * anywhere to represent "any text".

Note: I discovered that this system contains a bug which means items in the list can filter out more URLs than they should. I'm currently working on fixing this.

@ator-dev ator-dev added bug Something isn't working enhancement New feature or request planned Will be actioned labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request planned Will be actioned
Projects
None yet
Development

No branches or pull requests

2 participants