Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not separate words and reset default options? #153

Open
tmpm697 opened this issue Apr 27, 2024 · 2 comments · Fixed by #156
Open

Do not separate words and reset default options? #153

tmpm697 opened this issue Apr 27, 2024 · 2 comments · Fixed by #156
Labels
enhancement New feature or request planned Will be actioned

Comments

@tmpm697
Copy link

tmpm697 commented Apr 27, 2024

reproduce:

1.  go to: https://daiderd.com/nix-darwin/manual/index.html#opt-nix.linux-builder.systems
2. use left mouse to select `nix.linux-builder`
3. right mouse click and select `Highlight Selection`
4. --> result: mark-my-search separates two: `nix` and `linux-builder`
   but we're expecting one word for searching `nix.linux-builder`

so if we can have option to keep not separate words for searching is better

another issue is that there's no reset options in mark-my-search's settings, so tweaking around and u'll get lost of what are defaults.

@ator-dev
Copy link
Member

ator-dev commented May 7, 2024

Thanks for the feedback! I see the problem with the current behaviour. We currently interpret any space or punctuation mark as a word break, but this should probably be changed to any space or punctuation mark followed by 1 or more spaces. I will make a release to address this.

another issue is that there's no reset options in mark-my-search's settings

You can actually see the defaults - in the Options page, every setting has two items, an editable one representing the current value (left), and a greyed-out readonly one representing the default value (right). To restore defaults, you can copy the default value. It's a bit tricky for the text boxes: you have to drag the mouse from one end of the readonly text box, and keep dragging until the whole text is selected, then Ctrl+C and Ctrl+V it into the editable one.

I plan to improve this in the release by adding a per-setting reset button and a reset all button. I will also try to make the saving behaviour more obvious.

@ator-dev ator-dev added enhancement New feature or request good-first-issue Good for newcomers planned Will be actioned labels May 7, 2024
@ator-dev ator-dev reopened this May 9, 2024
@ator-dev ator-dev removed the good-first-issue Good for newcomers label May 9, 2024
@ator-dev
Copy link
Member

ator-dev commented May 9, 2024

I will close this issue once I've actually published the changes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Will be actioned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants