Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It breaks LinkedIn search page. #134

Open
juanmalvarezvaa opened this issue Jun 17, 2023 · 4 comments
Open

It breaks LinkedIn search page. #134

juanmalvarezvaa opened this issue Jun 17, 2023 · 4 comments
Labels
bug Something isn't working planned Will be actioned

Comments

@juanmalvarezvaa
Copy link

When trying to use the extension on a LinkedIn search.. some parts of the search become unresponsive.

@ator-dev
Copy link
Member

Thanks for the report!

I wasn't able to reproduce the issue - I tried searching for a few keywords on LinkedIn, and changed pages a few times, but the search was still responsive. Can you describe what can cause the issue please?

@ator-dev ator-dev added bug Something isn't working help-wanted Extra attention is needed labels Jun 18, 2023
@juanmalvarezvaa
Copy link
Author

Yes sure! Sorry for the delay.

In the jobs search, having the extensions enabled make changing offers impossible. The URL changed, but it's not rendered on the screen.
For example:
image
There I'm in the first job, and then I click on the second one:
image
As you can see, nothing changed except the URL.

No error on the Chrome Console.

Thanks!

@ator-dev
Copy link
Member

ator-dev commented Jun 20, 2023

Thank you, the new information is helpful!

I have some good news and some bad news.

Firstly, I don't think the problem as it stands is solvable. Like all search highlighters, Mark My Search has to break up text to insert highlighting elements, which is a problem for some sites. Specifically, I discovered that LinkedIn stores some data in regular elements with display: none - which can't be detected as it would massively impact efficiency - and I suspect this is the reason it breaks. For whatever reason it works well on Firefox.

image

Luckily Mark My Search has a mode built to solve this problem. If you open the extension options (from about:extensions or the popup > Options), uncheck "Use CLASSIC highlighting" and save, you should find that it works better. However, my testing on LinkedIn surfaced some issues with the experimental highlighter:

  • (Chrome only) At the time of page load, it spams the console with warnings that highlight caching isn't working. Should be safe to ignore but I need to investigate it.
  • (Chrome only) Although highlighting occurs, the keyword buttons never light up to indicate that matches were found.
  • When switching jobs, highlighting is not updated immediately.
    • (Firefox only) This is usually fixed by scrolling out of view and back again.
    • (Chrome only) I had to massively resize the window to force it to refresh.

However, it doesn't break LinkedIn, and it does work (in that highlighting appears and is internally correct, even if it doesn't always get visually updated). I will get back to you with updates on this, as I would love to make the new "PAINT" highlighter available for regular use!

@ator-dev ator-dev added planned Will be actioned and removed help-wanted Extra attention is needed labels Jun 20, 2023
@juanmalvarezvaa
Copy link
Author

Ok thanks! That's nice to know, and thanks for the fast answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned Will be actioned
Projects
None yet
Development

No branches or pull requests

2 participants