Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] PDF highlighting #104

Open
ator-dev opened this issue Mar 19, 2023 · 0 comments
Open

[Feature Request] PDF highlighting #104

ator-dev opened this issue Mar 19, 2023 · 0 comments
Labels
enhancement New feature or request plugin Will be actioned in a separate 'plugin' add-on

Comments

@ator-dev
Copy link
Member

ator-dev commented Mar 19, 2023

PDF highlighting is something I've seen highly requested for highlighter extensions, including current users of Mark My Search. While it is impossible to do this in any browser's native PDF viewer for security reasons, it is relatively easy to do so in a custom viewer implementation. There are two main options for doing this in an extension:

  • Add methods (e.g. toolbar button, shortcut, right-click menu option) to open the current PDF/link in a trustworthy and lightweight PDF viewer website
    • Easy to support, little development tax, possible to use a more feature-rich viewer
    • User must be connected to the internet and the viewer will be slower than the default (even if the viewer has an excellent PWA implementation, they must at least be connected on first run)
  • Add methods to open the current PDF/link in an integrated offline PDF viewer
    • Full trust, fast, lightweight, offline
    • Additional development burden, need of using potentially large dedicated libraries, must include a copy of MMS's highlighting script (plus dependencies) due to extension page restrictions
    • Unclear whether or not this can work in Chrome, since for some absurd reason extensions cannot interact with their own pages unlike in Firefox - is another offline method possible?

I propose that a dedicated MMS PDF plug-in be created which implements at least the first of these options. If at all feasible, it should integrate a PDF viewer library as per the second option, as that has the potential to be optimal for the user experience, even if only available in Firefox for now.

Edit 2023-04-01: Still planned, but for-plugin implies being actioned. I will be able to start work on these in approximately 3 months.

@ator-dev ator-dev added enhancement New feature or request plugin Will be actioned in a separate 'plugin' add-on labels Mar 19, 2023
@ator-dev ator-dev changed the title PDF highlighting [FeatPDF highlighting Mar 19, 2023
@ator-dev ator-dev changed the title [FeatPDF highlighting [Feature Request] PDF highlighting Mar 19, 2023
@ator-dev ator-dev added the planned Will be actioned label Mar 19, 2023
@ator-dev ator-dev removed the planned Will be actioned label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Will be actioned in a separate 'plugin' add-on
Projects
Status: Concept
Development

No branches or pull requests

1 participant