Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of deactivated highlighting when still on the original 'search page' #103

Open
ator-dev opened this issue Mar 17, 2023 · 2 comments
Labels
enhancement New feature or request planned Will be actioned

Comments

@ator-dev
Copy link
Member

When a user deactivates MMS in a tab, they expect it to stay off - at least while on the same page. For convenience reasons this is not the case, as automatic activation occurs whenever a page with search keywords is loaded (including refreshes).

Perhaps MMS could have an alternate behaviour, like re-enabling only if the current search keywords are different from the last ones in the tab? This will need more consideration to avoid apparent inconsistency and so confusion.

@ator-dev ator-dev added enhancement New feature or request review Needs further consideration labels Mar 17, 2023
@ator-dev
Copy link
Member Author

ator-dev commented Mar 17, 2023

For a visual example, this DuckDuckGo page will always reactivate automatically because it has search keywords (mark+my+search -> mark my search)

image


Noticed 03-28: many search engines are considered to have performed a navigation (or update the URL) when reflecting user decisions such as opening an image into a larger view. For this reason the current situation is fairly unworkable.

@ator-dev
Copy link
Member Author

Current plan: to have a 'grace period' which ends as soon as a navigation occurs which does not generate the same set of keywords via the URL (or would not, ignoring the stoplist?). Within this period, navigations would not be allowed to restore deactivated highlighting.

@ator-dev ator-dev added planned Will be actioned and removed review Needs further consideration labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Will be actioned
Projects
None yet
Development

No branches or pull requests

1 participant