Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ls_files for generating the codecov manifest #4

Open
Daverball opened this issue Mar 10, 2022 · 0 comments
Open

Improve ls_files for generating the codecov manifest #4

Daverball opened this issue Mar 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Daverball
Copy link
Member

Daverball commented Mar 10, 2022

Currently the plugin assumes it's either being run from the project base directory or inside a git repository with the optional GitPython dependency installed to generate the manifest for the coverage results.

There's two improvements that should be made here:

  1. Without GitPython it should be possible to manually set the project root using a command line option or environment variable, e.g. --codecov-project-root
  2. Whenever coverage is measured across a subfolder in the project using --cov=subdir or equivalent config file options we should filter the output of ls_files according to this sub directory, the manifest should still list these files relative to the project root however, because otherwise codecov.yaml would need to contain path fixes.
@Daverball Daverball added the enhancement New feature or request label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant