Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

announce date / release schedule #10

Open
timelyportfolio opened this issue Feb 16, 2015 · 6 comments
Open

announce date / release schedule #10

timelyportfolio opened this issue Feb 16, 2015 · 6 comments

Comments

@timelyportfolio
Copy link
Contributor

What is your timeline for release? I would love to feature this on http://buildingwidgets.com/blog, but don't want to prematurely announce.

@sdwfrost
Copy link
Owner

Dear @timelyportfolio

The hackathon is over, so I don't have any dedicated time to this - I spent a bit of Friday making sure that the package passed R CMD CHECK (which it does). There are a few things that need to be fixed, and a few improvements before I'd be happy with releasing.

  1. The major bug right now is in selections (look at Sergei's standalone widget in inst/standalone); the main utility of the widget is the ability to tag nodes with labels, which are inserted into the Newick string. However, as some tags would break the Newick string, there is some validation code used. To try to understand (and hence later enhance) the code, I've worked through the event handlers, but there's a bug such that one can't add multiple tags or change the default 'Foreground' one.
  2. The dashboard is a bit ugly; the widget is bundled with Bootstrap, so I just need to add in a grid component.
  3. I added support for saving the (tagged) Newick tree to file, and an exit button (which I should make conditional on Shiny), which if run in a Shiny app, exits to the R console. It prints out the tagged tree (using Shiny.onInputChange), but I haven't worked out how to return as e.g. a Newick string that could be parsed back into ape.

There are some additional enhancements that I'd like to make, to improve support for large trees e.g. using something like Magnifier.js, and/or D3's fisheye/Cartesian distortion. These aren't essential, and someone may pick these up before I do if attention is drawn with a blog post.

@sdwfrost
Copy link
Owner

PS. Oliver Ratmann @olli0601 was working on a feature to annotate the labels of the tree e.g. with sparklines, and given the presence of phylowidget.org, we probably need to change the name too.

@olli0601
Copy link
Collaborator

Hi Simon - thanks.
I d be keen to continue working on the label annotation, but need help with D3 and phylotree.js. Happy to share the bits that I got working if there is interest:

  • cast data.frame with label annotation into D3 friendly format
  • annotate phylotree.js nodes with additional information

TODO:

  • plot the areas. Sparklines don t support an x arguments, so I was aiming to subclass the area function.

Ultimately, I was aiming to achieve this (which I have in R but becomes very quickly very cluttered because a lot of different information is available):

screen shot 2015-02-17 at 07 37 54

olli

@sdwfrost
Copy link
Owner

Dear @olli0601 , please submit a pull request when you're ready! The more development, the better...

@liamxg
Copy link

liamxg commented Aug 18, 2023

@olli0601 what is your figure meaning here?

@liamxg
Copy link

liamxg commented Aug 18, 2023

Hi Simon - thanks. I d be keen to continue working on the label annotation, but need help with D3 and phylotree.js. Happy to share the bits that I got working if there is interest:

  • cast data.frame with label annotation into D3 friendly format
  • annotate phylotree.js nodes with additional information

TODO:

  • plot the areas. Sparklines don t support an x arguments, so I was aiming to subclass the area function.

Ultimately, I was aiming to achieve this (which I have in R but becomes very quickly very cluttered because a lot of different information is available):

screen shot 2015-02-17 at 07 37 54

olli

any code to plot the figure? @olli0601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants