You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For sequential data, it should not be possible for the sequence key to be the same as a context column. This is because the sequence key is an identifier for each sequence, whereas a context column is just another column that happens to never vary within a sequence. There is no need to declare a sequence key as a context column because a sequence key is already guaranteed not to vary within a sequence -- rather, it is defining what a sequence is.
Yet, the code somehow allows me to instantiate a PARSynthesizer with a context column the same as the sequence key. When I try to fit it, I get an error that is not really relevant to the issue.
[/usr/local/lib/python3.10/dist-packages/sdv/sequential/par.py](https://localhost:8080/#) in update_transformers(self, column_name_to_transformer)
298 """
299 if set(column_name_to_transformer).intersection(set(self.context_columns)):
--> 300 raise SynthesizerInputError(
301 'Transformers for context columns are not allowed to be updated.')
302
SynthesizerInputError: Transformers for context columns are not allowed to be updated.
Expected Behavior
I should not be allowed to even instantiate a PARSynthesizer if any of the context columns are sequence keys. This should immediately throw an error explaining that it is not allowed.
SynthesizerInputError: The sequence key ('A') cannot be a context column. To proceed, please remove the sequence key from the 'context_columns' parameter.
The text was updated successfully, but these errors were encountered:
Environment Details
Error Description
For sequential data, it should not be possible for the sequence key to be the same as a context column. This is because the sequence key is an identifier for each sequence, whereas a context column is just another column that happens to never vary within a sequence. There is no need to declare a sequence key as a context column because a sequence key is already guaranteed not to vary within a sequence -- rather, it is defining what a sequence is.
Yet, the code somehow allows me to instantiate a
PARSynthesizer
with a context column the same as the sequence key. When I try to fit it, I get an error that is not really relevant to the issue.Error:
Expected Behavior
I should not be allowed to even instantiate a
PARSynthesizer
if any of the context columns are sequence keys. This should immediately throw an error explaining that it is not allowed.The text was updated successfully, but these errors were encountered: