From aea750578e0fc5a48654b8ed32b17b168635c2cb Mon Sep 17 00:00:00 2001 From: fealho Date: Mon, 24 Jan 2022 20:28:37 -0800 Subject: [PATCH 1/2] Change none no nan --- tests/unit/transformers/test_categorical.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/transformers/test_categorical.py b/tests/unit/transformers/test_categorical.py index 9fdd1cd63..d93a1e00d 100644 --- a/tests/unit/transformers/test_categorical.py +++ b/tests/unit/transformers/test_categorical.py @@ -156,7 +156,7 @@ def test__get_intervals_nans(self): categorical value (start, end). """ # Setup - data = pd.Series(['foo', np.nan, None, 'foo', 'foo', 'tar']) + data = pd.Series(['foo', np.nan, np.nan, 'foo', 'foo', 'tar']) # Run result = CategoricalTransformer._get_intervals(data) From 25f027881b7b763c2c4d198c78208efcf30a0941 Mon Sep 17 00:00:00 2001 From: fealho Date: Tue, 25 Jan 2022 14:52:53 -0800 Subject: [PATCH 2/2] Convert all data to np.nan --- rdt/transformers/categorical.py | 1 + tests/unit/transformers/test_categorical.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rdt/transformers/categorical.py b/rdt/transformers/categorical.py index 97bcf71fb..b0b0b1636 100644 --- a/rdt/transformers/categorical.py +++ b/rdt/transformers/categorical.py @@ -89,6 +89,7 @@ def _get_intervals(data): dict: intervals for each categorical value (start, end). """ + data = data.fillna(np.nan) frequencies = data.value_counts(dropna=False) start = 0 diff --git a/tests/unit/transformers/test_categorical.py b/tests/unit/transformers/test_categorical.py index d93a1e00d..9fdd1cd63 100644 --- a/tests/unit/transformers/test_categorical.py +++ b/tests/unit/transformers/test_categorical.py @@ -156,7 +156,7 @@ def test__get_intervals_nans(self): categorical value (start, end). """ # Setup - data = pd.Series(['foo', np.nan, np.nan, 'foo', 'foo', 'tar']) + data = pd.Series(['foo', np.nan, None, 'foo', 'foo', 'tar']) # Run result = CategoricalTransformer._get_intervals(data)