Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate component probabilities for the ClusterBasedNormalizer #697

Open
fealho opened this issue Aug 29, 2023 · 0 comments
Open

Investigate component probabilities for the ClusterBasedNormalizer #697

fealho opened this issue Aug 29, 2023 · 0 comments

Comments

@fealho
Copy link
Member

fealho commented Aug 29, 2023

Problem Description

During the transform, we add 1e-6 to the probability of choosing any component. It is not obvious why that would be the case, so it should be investigated.

Expected behavior

Either remove the following lines or explain why they are there.

component_prob_t = component_probs[i] + 1e-6
component_prob_t = component_prob_t / component_prob_t.sum()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant