Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BinaryEncoder #539

Open
amontanez24 opened this issue Aug 17, 2022 · 0 comments
Open

Remove BinaryEncoder #539

amontanez24 opened this issue Aug 17, 2022 · 0 comments
Labels
feature request Request for a new feature

Comments

@amontanez24
Copy link
Contributor

Problem Description

The BinaryEncoder is not as effective as the LabelEncoder so it should be replaced with it and removed down the line.

Expected behavior

  • Change the default transformer for boolean columns to the LabelEncoder
  • Raise the following deprecation warning whenever users try to use the BinaryEncoder
    • This should be in the following methods:
      • update_transformers
      • update_transformers_by_sdtype
      • set_config
    • Use this message
      • Deprecation Warning: BinaryEncoder will no longer be supported in future versions of RDT. Please use the LabelEncoder instead.

Additional context
@amontanez24 amontanez24 added the feature request Request for a new feature label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Request for a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amontanez24