You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi.
I want to use this lib to manage amt device.
But some issues stops me to start:
1 When i'm connecting to device if login\pass is incorrect the main way to understand it is to compare result with 1.
Why you did not raise any exceptions?
In Client.init ,for example, make an auth checking request and raise errors.
2 And also there are print statements. It is better to use logging that i can disable out put if needed.
Can i make pull request to fix that issues or you have another opinion for each?
thx for library :)
The text was updated successfully, but these errors were encountered:
Hi.
I want to use this lib to manage amt device.
But some issues stops me to start:
1 When i'm connecting to device if login\pass is incorrect the main way to understand it is to compare result with 1.
Why you did not raise any exceptions?
In Client.init ,for example, make an auth checking request and raise errors.
2 And also there are print statements. It is better to use logging that i can disable out put if needed.
Can i make pull request to fix that issues or you have another opinion for each?
thx for library :)
The text was updated successfully, but these errors were encountered: