Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging and exceptions #6

Open
inhumanitas opened this issue Dec 16, 2015 · 0 comments
Open

logging and exceptions #6

inhumanitas opened this issue Dec 16, 2015 · 0 comments

Comments

@inhumanitas
Copy link

Hi.
I want to use this lib to manage amt device.
But some issues stops me to start:

1 When i'm connecting to device if login\pass is incorrect the main way to understand it is to compare result with 1.
Why you did not raise any exceptions?
In Client.init ,for example, make an auth checking request and raise errors.

2 And also there are print statements. It is better to use logging that i can disable out put if needed.

Can i make pull request to fix that issues or you have another opinion for each?

thx for library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant