Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Provide easier access to view mat #15

Open
erinoerin opened this issue Sep 27, 2020 · 10 comments · May be fixed by #54
Open

Idea: Provide easier access to view mat #15

erinoerin opened this issue Sep 27, 2020 · 10 comments · May be fixed by #54

Comments

@erinoerin
Copy link
Collaborator

From Zesix 9/26 at 8:16 PM
"One of the things I don't like is having to click the faction to see the mat instead of just having all the mat images there"

@lightyearsaway
Copy link
Collaborator

Do you have any ideas about how this would look?

@avidmeher
Copy link
Collaborator

This is how it looks when I simply wrapped the hyperlink in Popover

image

@rezende
Copy link
Collaborator

rezende commented Oct 12, 2020

I had the idea of Popover before, for some reason it wasn't working at the time. It looks nice.

@lightyearsaway
Copy link
Collaborator

What do you think about using a Modal?

@avidmeher
Copy link
Collaborator

I thought about Modal first. However, it needs 2 clicks (1 to open and 1 to close) while Popover only requires the pointer to be in place, so it felt simpler. I don't know how effective Popover is in touch screen mode.

@lightyearsaway
Copy link
Collaborator

lightyearsaway commented Oct 13, 2020

I think personally I prefer Modal because a popover that big seems unwieldy, and also the large image taking some time to load makes the hovering experience of the popover not as attractive. It feels like loading something like this image should be the result of a deliberate action as opposed to hovering over something. It would be a little more awkward to get out of the popover as in the screenshot, you would need to move your cursor either a short distance up or a long distance in another direction to hide the popover, so the experience of accidentally hovering over the popover seems unpleasant.

I would still prefer a Modal to center the image in the screen and help the user focus on the image, but clicking to show a popover as opposed to hovering (which is the default behavior, so is what I assumed we were talking about) would be better IMO.

@lightyearsaway
Copy link
Collaborator

@erinoerin would love your thoughts here

@avidmeher
Copy link
Collaborator

avidmeher commented Oct 13, 2020

I would still prefer a Modal to center the image in the screen and help the user focus on the image, but clicking to show a popover as opposed to hovering (which is the default behavior, so is what I assumed we were talking about) would be better IMO.

Do you mean Model > Popover + click > Popover + hover OR Popover + click > Modal > Popover + hover ? ( > means better here )

I agree that accidental activation can be unpleasant with the hover mode, so the click mode should suffice. Also, the Modal docs make it look like we would need to define 3 functions to use it. I do like the draggable Modal, though.

As for the image size, with the new images, it looks like this when the image is scaled down to 25%
image

@lightyearsaway
Copy link
Collaborator

Personally, Modal > Popover (Click) > Popover (Hover). Being able to use it could change my mind, but as I'm imagining it, I think Modal is a bit more in line with expectations.

@avidmeher avidmeher linked a pull request Nov 21, 2020 that will close this issue
@avidmeher
Copy link
Collaborator

I fiddled around with getting the Modal dialog to appear with small margins for way too long and decided it's not worth any more of my time. Popover with click activation seems like it's designed to be used for this situation, and the code is much simpler with Popover. Pull request 54 created.

@avidmeher avidmeher linked a pull request Nov 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants