-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: Provide easier access to view mat #15
Comments
Do you have any ideas about how this would look? |
This is how it looks when I simply wrapped the hyperlink in Popover |
I had the idea of Popover before, for some reason it wasn't working at the time. It looks nice. |
What do you think about using a Modal? |
I thought about Modal first. However, it needs 2 clicks (1 to open and 1 to close) while Popover only requires the pointer to be in place, so it felt simpler. I don't know how effective Popover is in touch screen mode. |
I think personally I prefer Modal because a popover that big seems unwieldy, and also the large image taking some time to load makes the hovering experience of the popover not as attractive. It feels like loading something like this image should be the result of a deliberate action as opposed to hovering over something. It would be a little more awkward to get out of the popover as in the screenshot, you would need to move your cursor either a short distance up or a long distance in another direction to hide the popover, so the experience of accidentally hovering over the popover seems unpleasant. I would still prefer a Modal to center the image in the screen and help the user focus on the image, but clicking to show a popover as opposed to hovering (which is the default behavior, so is what I assumed we were talking about) would be better IMO. |
@erinoerin would love your thoughts here |
Personally, Modal > Popover (Click) > Popover (Hover). Being able to use it could change my mind, but as I'm imagining it, I think Modal is a bit more in line with expectations. |
I fiddled around with getting the Modal dialog to appear with small margins for way too long and decided it's not worth any more of my time. Popover with click activation seems like it's designed to be used for this situation, and the code is much simpler with Popover. Pull request 54 created. |
From Zesix 9/26 at 8:16 PM
"One of the things I don't like is having to click the faction to see the mat instead of just having all the mat images there"
The text was updated successfully, but these errors were encountered: