Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prometheus proxy export #95

Open
hopugop opened this issue Nov 20, 2023 · 3 comments
Open

Support prometheus proxy export #95

hopugop opened this issue Nov 20, 2023 · 3 comments
Labels

Comments

@hopugop
Copy link

hopugop commented Nov 20, 2023

TF provider should allow users to enable "export metrics" when creating a cluster.

@rjeczalik
Copy link
Contributor

What should be the desired user interface, can you provide more details?

I think just mimicking the "Export metrics" checkbox from the UI is not enough, because an automation would want also to configure the scrapping from our proxy.

This needs more details.

@hopugop
Copy link
Author

hopugop commented Dec 31, 2023

Mimicking the "Export metrics" checkbox from the UI is enough for this issue.

@rjeczalik rjeczalik added documentation Improvements or additions to documentation status/needs-design and removed documentation Improvements or additions to documentation labels Mar 19, 2024
@rjeczalik
Copy link
Contributor

Mimicking the "Export metrics" checkbox from the UI is enough for this issue.

It is not enough for the issue, in Terraform Provider support for a feature needs to be complete.

If we allow to enable certain functionality through the resource attributes, we need to provide a way to consume them.

The list of features for the cluster resource will be ever-growing - we should discuss sooner than later how to find a better way of introducing them, rather than just keep adding new attributes. New attributes requires handling of old state files. Maybe it would be better to create another add-on resource, like scylladbcloud_cluster_metrics? I would prefer this way, as it does not touch the cluster, extending it with more responsibilities.

Regardless whatever the final design, before we can implement this, there should be a formal proposal what and how to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants