cassandra-stress: switch create table to use keyspace.table format #358
Conversation
Stop using "Use keyspace" since it can fail when using multiple stress commands in parallel due to a race condition. fixes: scylladb#356
| @@ -152,7 +150,7 @@ String createStandard1StatementCQL3(StressSettings settings) | |||
| StringBuilder b = new StringBuilder(); | |||
|
|
|||
| b.append("CREATE TABLE IF NOT EXISTS ") | |||
| .append("standard1 (key blob PRIMARY KEY "); | |||
| .append("\""+keyspace+"\"".standard1 (key blob PRIMARY KEY "); | |||
There was a problem hiding this comment.
createCounter1StatementCQL3 might be missing it as well, even that I didn't found any place in the code that calls it.
|
ping |
|
I never had the chance to test it, but it's also very rare case, so not urgent. |
|
Does it really solve #356? I don't see why it'd solve that problem - if |
|
The problem happens when you run multiple clients at the same time. I still need to test that it doesn't break anything, just didn't find a time for it yet. |
|
What's holding this? |
This PR lacks any explanation/proof why this really fixes the problem. And personally I believe that this doesn't fix anything. If it really fixed the problem, that would mean that there is a serious bug in Java Driver around USE statements that should be fixed and not worked around. |
see scylladb/scylladb#16969, it's a really issue in scylla's end, that create KS doesn't always return to the driver that the schema has changed. anyhow this change is removing one command, that lower the changes of this issue to be happening |
|
taking this change locally, it won't work. the rest of the calls in c-s are depended on this USE call... one need to go all over the place to make sure it's mentioning the keyspace in any CQL command is executed |
|
The real fix should be this one: scylladb/scylladb#16969. |
Stop using "Use keyspace" since it can fail when using multiple stress commands in parallel due to a race condition.
fixes: #356