Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScyllaDBCluster webhook validation #2271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ScyllaDBCluster webhook validation #2271

wants to merge 2 commits into from

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Dec 16, 2024 •
edited
Loading

Description of your changes:

Adds validation rules for v1alpha1.ScyllaDBCluster to existing validating webhook.

Which issue is resolved by this Pull Request:
Resolves #2280

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 16, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@zimnx: GitHub didn't allow me to request PR reviews from the following users: zimnx.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:

Adds validation rules for v1alpha1.ScyllaDBCluster to existing validating webhook.

Which issue is resolved by this Pull Request:
Resolves #

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 16, 2024
@zimnx zimnx force-pushed the scylladbcluster-webhook branch 3 times, most recently from 9a65306 to 6ae7f48 Compare December 16, 2024 19:57
@zimnx zimnx force-pushed the scylladbcluster-webhook branch from 6ae7f48 to 38ef9a7 Compare December 17, 2024 16:15
@zimnx zimnx changed the title [WIP] Add ScyllaDBCluster webhook validation Add ScyllaDBCluster webhook validation Dec 18, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2024
@zimnx
Copy link
Collaborator Author

zimnx commented Dec 18, 2024

/cc rzetelskik
/cc tnozicka

Ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add webhook validation to v1alpha1.ScyllaDBCluster
1 participant
@zimnx