Skip to content

Commit 3c3e18d

Browse files
committed
JAVA: add test publish step
1 parent 3787787 commit 3c3e18d

File tree

4 files changed

+30
-13
lines changed

4 files changed

+30
-13
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212
jobs:
1313
compile:
1414
name: Compile Java Module
15-
runs-on: ubuntu-latest
15+
runs-on: ubuntu-20.04
1616
defaults:
1717
run:
1818
working-directory: ./java
@@ -23,6 +23,11 @@ jobs:
2323
distribution: temurin
2424
java-version: 8
2525
cache: maven
26+
server-id: ossrh
27+
server-username: MAVEN_USERNAME
28+
server-password: MAVEN_CENTRAL_TOKEN
29+
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
30+
gpg-passphrase: MAVEN_GPG_PASSPHRASE
2631

2732
- name: Compile Tests
2833
run: make compile compile-test

.github/workflows/publish-java-package.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ on:
77
required: true
88
type: string
99

10+
env:
11+
IS_CICD: 1
12+
1013
jobs:
1114
compile:
1215
name: Publish the Java Package to Maven Central

java/Makefile

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,29 @@
1+
mvn = mvn
2+
3+
ifdef IS_CICD
4+
mvn = mvn --no-transfer-progress
5+
endif
6+
7+
18
clean:
2-
mvn clean
9+
$mvn clean
310

411
verify:
5-
mvn verify
6-
mvn javadoc:test-javadoc
7-
mvn javadoc:test-aggregate
8-
mvn javadoc:test-jar
9-
mvn javadoc:test-resource-bundle
12+
${mvn} verify
13+
${mvn} javadoc:test-javadoc
14+
${mvn} javadoc:test-aggregate
15+
${mvn} javadoc:test-jar
16+
${mvn} javadoc:test-resource-bundle
17+
${mvn} javadoc:jar-no-fork
18+
${mvn} javadoc:jar
1019

1120
fix:
12-
mvn com.coveo:fmt-maven-plugin:format
13-
echo y | mvn javadoc:fix
14-
echo y | mvn javadoc:test-fix
21+
${mvn} com.coveo:fmt-maven-plugin:format
22+
echo y | ${mvn} javadoc:fix
23+
echo y | ${mvn} javadoc:test-fix
1524

1625
compile:
17-
mvn compile
26+
${mvn} compile
1827

1928
compile-test:
20-
mvn test-compile
29+
${mvn} test-compile

java/src/main/java/com/scylladb/alternator/AlternatorLiveNodes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public void checkIfRackAndDatacenterSetCorrectly() throws FailedToCheck, Validat
302302
}
303303

304304
/**
305-
* Returns true if remote node supports /localnodes?rack=\<\>\&dc=\<datacenter\>. If it can't
305+
* Returns true if remote node supports /localnodes?rack=`rack`&amp;dc=`datacenter`. If it can't
306306
* conclude by any reason it throws {@link
307307
* com.scylladb.alternator.AlternatorLiveNodes.FailedToCheck}
308308
*

0 commit comments

Comments
 (0)