Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixscape classification #688

Open
NguyenLuongHa opened this issue Dec 13, 2024 · 2 comments
Open

Mixscape classification #688

NguyenLuongHa opened this issue Dec 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@NguyenLuongHa
Copy link

Report

While further exploring the pipeline, I have encountered a couple of additional questions:

  1. When separating KO and NP, I noticed that in typical practices, results are iteratively updated until convergence is achieved.
    However, your approach seems to focus on finding a consistent result between two consecutive iterations. Could you kindly clarify this difference?
    (Please see the attachment for further details.)

Image

  1. In the tutorial document, the code snippet:
    ms.mixscape(adata=mdata["rna"], control="NT", labels="gene_target", layer="X_pert")  

Should it include the "split_by" parameter?

Version information

No response

@NguyenLuongHa NguyenLuongHa added the bug Something isn't working label Dec 13, 2024
@NguyenLuongHa
Copy link
Author

NguyenLuongHa commented Dec 16, 2024

@Lilly-May
In pull request #683, you're using random_state for the GaussianMixture object. This suggests that the while loop might be intended to be iterative, updating its behavior with each iteration.

Additionally, within the while loop, the guide_cells variable should likely use the new_class_name instead of the original labels. This would make the loop operate on the newly assigned class names

@Lilly-May
Copy link
Collaborator

Hi @NguyenLuongHa, thanks for opening this issue. I'll look into this ASAP!

@Lilly-May Lilly-May self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants