Skip to content

[Feat] Support axiom cli sdk #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

[Feat] Support axiom cli sdk #206

wants to merge 34 commits into from

Conversation

@noel2004
Copy link
Member

@noel2004 noel2004 commented Oct 28, 2025 •
edited
Loading

Working plan:

  • Support handling axiom's stuff (input and output_proof) in scroll-zkvm-types crate
  • Integrate axiom-sdk into Integration test so e2e can be run on axiom's proving cloud
  • Integrate axiom-sdk (which is basically a http client with some utilities) into scroll monorepo so the prover in scroll monorepo can run under "axiom cloud" mode

@github-actions github-actions bot added crate-prover Updates to the prover crate crate-integration Updates to the integration crate labels Oct 28, 2025
@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-build-guest Updates to building of guest programs crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit labels Nov 4, 2025
@lightsing lightsing marked this pull request as ready for review November 6, 2025 07:21
@roynalnaruto
Copy link
Collaborator

roynalnaruto commented Nov 10, 2025

@noel2004 while being WIP, can we turn it into a draft PR for now?

@noel2004 noel2004 marked this pull request as draft November 10, 2025 10:28
@noel2004
Copy link
Member Author

noel2004 commented Nov 10, 2025

@noel2004 while being WIP, can we turn it into a draft PR for now?

Yes. Should be a draft PR

@github-actions github-actions bot removed crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit labels Nov 11, 2025
@github-actions github-actions bot added crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit labels Nov 11, 2025
lispc
lispc reviewed Nov 13, 2025
View reviewed changes
crates/build-guest/src/main.rs
)?;
println!("{LOG_PREFIX} Uploaded program to Axiom program_id={program_id}");
axiom_program_ids[project_name] = serde_json::Value::String(program_id);
}
Copy link
Collaborator

@lispc lispc Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so now since it is automatically uploaded, let us don't set AXIOM_API_KEY unless needed. (eg: dont set it in github action.). We dont. want to upload too many unused programs to axiom cloud.

lispc
lispc reviewed Nov 13, 2025
View reviewed changes
crates/types/src/axiom.rs
pub mod config {
pub const CHUNK: &str = "cfg_01k9b6y2tcnw8b969vnk6d7eyq";
pub const BATCH: &str = "cfg_01k9b6wa8hx37z42kd41cqrkfs";
pub const BUNDLE: &str = "cfg_01k9b6xjt0va25sy94tztwehs7";
Copy link
Collaborator

@lispc lispc Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment to explain that these 3 const strings are related to 3 openvm.toml. If those change, we should(how? add a doc link?) change these cfg_xxx too.

lispc
lispc reviewed Nov 13, 2025
View reviewed changes
crates/types/src/openvm.rs

impl super::ProvingTask {
pub fn build_openvm_input(&self) -> OpenVMInput {
let mut input = Vec::new();
Copy link
Collaborator

@lispc lispc Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a doc link. Either an axiom doc link, or an openvm code link? (inside openvm::cli crate?)

lispc
lispc reviewed Nov 13, 2025
View reviewed changes
Cargo.toml
bytesize = "2.0.1"
url = "2.5.4"
tokio = "1"
axiom-sdk = { git = "https://github.com/axiom-crypto/axiom-api-cli.git", branch = "feat/upload-exe-raw" }
Copy link
Collaborator

@lispc lispc Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should fix this later.

lispc
lispc approved these changes Nov 13, 2025
View reviewed changes
Copy link
Collaborator

@lispc lispc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally good.

Change needed:

separate build and upload to axiom cloud. Also upload elfs to s3.
"upload to axiom cloud" must be a manual action. Either a standalone rust program, or a build-guest sub command, or a bash script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lispc lispc lispc approved these changes

@roynalnaruto roynalnaruto Awaiting requested review from roynalnaruto roynalnaruto is a code owner

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

crate-batch-circuit Updates to the guest program batch-circuit crate-build-guest Updates to building of guest programs crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noel2004 @roynalnaruto @lispc @lightsing