Skip to content

[Primitives] Make NewBlock::signature Typed #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frisitano opened this issue Apr 24, 2025 · 1 comment
Open

[Primitives] Make NewBlock::signature Typed #71

frisitano opened this issue Apr 24, 2025 · 1 comment
Assignees
Labels
milestone 5 This issue is part to Milestone 5 of the Rollup Node plan primitives
Milestone

Comments

@frisitano
Copy link
Collaborator

frisitano commented Apr 24, 2025

I would like to have a solution that ensures correct typing, such that we have:

/// A message that is used to announce a new block to the network.
#[derive(Clone, Debug, PartialEq, Eq, RlpEncodable, RlpDecodable)]
pub struct NewBlock {
    /// The signature from the block author.
    pub signature: Signature,
    /// The block that is being announced.
    pub block: reth_scroll_primitives::ScrollBlock,
}

The reason we currently don't have this is because Signature does not implement Encodable. We may be able to address this by implementing Encodable ourselves on this type instead of leveraging the macro but I'm not sure. I will open an issue.

Originally posted by @frisitano in #68 (comment)

@frisitano frisitano added this to the Milestone 5 milestone Apr 24, 2025
@frisitano frisitano added this to Reth Apr 24, 2025
@frisitano frisitano added the milestone 5 This issue is part to Milestone 5 of the Rollup Node plan label Apr 24, 2025
@greged93
Copy link
Collaborator

Link to the alloy issue: alloy-rs/core#938

@greged93 greged93 changed the title Make NewBlock::signature Typed [Primitives] Make NewBlock::signature Typed Apr 24, 2025
@frisitano frisitano self-assigned this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone 5 This issue is part to Milestone 5 of the Rollup Node plan primitives
Projects
Status: No status
Development

No branches or pull requests

2 participants