Skip to content

[Primitives] Make NewBlock::signature Typed #71

Description

@frisitano

I would like to have a solution that ensures correct typing, such that we have:

/// A message that is used to announce a new block to the network.
#[derive(Clone, Debug, PartialEq, Eq, RlpEncodable, RlpDecodable)]
pub struct NewBlock {
    /// The signature from the block author.
    pub signature: Signature,
    /// The block that is being announced.
    pub block: reth_scroll_primitives::ScrollBlock,
}

The reason we currently don't have this is because Signature does not implement Encodable. We may be able to address this by implementing Encodable ourselves on this type instead of leveraging the macro but I'm not sure. I will open an issue.

Originally posted by @frisitano in #68 (comment)

Metadata

Metadata

Assignees

Labels

milestone 5This issue is part to Milestone 5 of the Rollup Node planprimitives

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
No status

Relationships

None yet

Development

No branches or pull requests

Issue actions